Medical - Add 'Open (Backpack)' action to dead units

[LinkIsGrim]

When merged this pull request will:

• Title.
• Improve condition on 'Inventory' action.
• Close Medical - Hide/Reimplement "Open Bag (Backpack)" action on unconscious units. #8084.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[PabstMirror]

it does seem to work on dead people, but I also see this note

            // 26.8.2013 HOTFIX CardA: ATOpenBag can be processed with a live soldier's bag only
            // because some actions between bag and other containers(like ground,...)
            // needs unit->Brain() which is invalid for a dead soldier(dead soldier has no brain)

[PabstMirror]

I really don't think we can disable those vanilla actions
but still might be able to add the open backpack action assuming it doesn't cause something to explode

[PabstMirror]

noticed actions don't get re-added when unit respawns,
also effects the previous unconscious-gear action

[johnb432]

Why not add something similar to this instead?
It adds the backpack interaction, regardless if unit is alive or dead.

[LinkIsGrim]

This is for scroll wheel actions specifically.

[johnb432]

This is for scroll wheel actions specifically.

Sorry, I don't know how, but I missed that part.

Nonetheless, the condition checking of what I linked might be worth using here (part of FUNC(hasInventory)):

!lockedInventory _this && {maxLoad _this > 0} && {getNumber (configOf _this >> "disableInventory") != 1} // _this being backpackContainer

(I added it above, beneath an already existing suggestion)

[johnb432]

This should resolve the dead unit and respawning issues mentioned.
Not entirely sure about the CBA event register placement (should it be in preInit or postInit?).

Edit: Forgot to remove some test code, so the commit after the one mentioned above resolves those issues.

[LinkIsGrim]

This should resolve the dead unit and respawning issues mentioned. Not entirely sure about the CBA event register placement (should it be in preInit or postInit?).

Edit: Forgot to remove some test code, so the commit after the one mentioned above resolves those issues.

LGTM. Moved to postInit.

[PabstMirror]

getting double backpack actions for dead units
and the open bag doesn't seem to work on dead units

edit: this is for a unit that I put health at 0 in 3den

openbag.mp4

[johnb432]

getting double backpack actions for dead units and the open bag doesn't seem to work on dead units

I assume it's because the EH and the allDeadMen code are executed at the same time.
I guess we could add a variable to the unit telling us the action has been added?

So in FUNC(addInventoryActions):

if (_unit getVariable [QGVAR(actions), false]) exitWith {};

_unit setVariable [QGVAR(actions), true];

[johnb432]

getting double backpack actions for dead units and the open bag doesn't seem to work on dead units

edit: this is for a unit that I put health at 0 in 3den
openbag.mp4

The doubling of the actions should be fixed now.

However, I could not replicate the open bag not working on dead units, even ones killed in the editor.
I was testing in self-hosted MP, regardless of being the server of the client I can't replicate the issue you describe.

[PabstMirror]

mission showing backpack action not working on dead units
testBackpacks.Stratis.zip

[johnb432]

mission showing backpack action not working on dead units testBackpacks.Stratis.zip

I'm not sure if this will be fixed. It might be related to https://feedback.bistudio.com/T126030#2482353 in part, so it might be fixed if KK decides to look into units set to 0 health in the editor.

[PabstMirror]

fixed double actions by

• add to allUnits + allDeadMen
• add class init EH without retro flag

[PabstMirror]

We can just keep an eye out if the old notes about OpenBag action actually cause problems