Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable getMetadata to query any document #17

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

blefebvre
Copy link
Contributor

Description

Add an optional param to the getMetadata function to enable any document to be queried.

Related Issue

Relates to an PR discussion & issue on the WKND repo: hlxsites/wknd#40

How Has This Been Tested?

Added unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blefebvre. I agree that in the fragment case, this is useful.

@kptdobe kptdobe merged commit a7a5111 into adobe:main Sep 27, 2023
1 check passed
kptdobe pushed a commit that referenced this pull request Sep 27, 2023
# [1.3.0](v1.2.1...v1.3.0) (2023-09-27)

### Features

* enable getMetadata to query any document ([#17](#17)) ([a7a5111](a7a5111))
@kptdobe
Copy link
Contributor

kptdobe commented Sep 27, 2023

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants