Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#39 - Featured Article component does not pull title and description from the referenced article #40

Merged
merged 2 commits into from
Sep 22, 2023
Merged

#39 - Featured Article component does not pull title and description from the referenced article #40

merged 2 commits into from
Sep 22, 2023

Conversation

blefebvre
Copy link
Collaborator

Also:

  • Update sample authoring documents in documents.zip
  • Address lint warnings

Fix #39

Test URLs:

@blefebvre
hlxsites#39 - Featured Article component does not pull title and desc…
6bb0988 
…ription from the referenced article

Update sample authoring documents in documents.zip
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 21, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 21, 2023

Page Scores Audits Google
/magazine PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dylandepass
Copy link
Contributor

dylandepass commented Sep 21, 2023 •
edited
Loading

@blefebvre I'd probably just fix this in featured-article instead of changing lib-franklin.js. We pretty much always advise customers to avoid doing that for upgrading reasons (doesn't happen often but has happened in the past). Especially since we are moving to a more of a packed distribution of lib-franklin (soon to be aem.js), probably best we don't change anything here.

Also, if you think this would be good to support in aem.js you should open a PR ;)
https://github.com/adobe/aem-lib

@blefebvre
hlxsites#39 - Featured Article component does not pull title and desc…
6726745 
…ription from the referenced article

Move getMetadata override which accepts a document as 2nd parameter to featured-article.js to avoid changing lib-franklin.js
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 22, 2023

Page Scores Audits Google
/magazine PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@blefebvre blefebvre merged commit ffef8f0 into hlxsites:main Sep 22, 2023
2 checks passed
@blefebvre blefebvre mentioned this pull request Sep 22, 2023
Merged
10 tasks
@blefebvre
Copy link
Collaborator Author

@dylandepass, thanks for the review and good idea on the PR — I've proposed adobe/aem-lib#17

FentPams added a commit that referenced this pull request Aug 7, 2024
@FentPams
Squashed 'plugins/experimentation/' changes from 9db8662..942948d
6d370f4 
942948d Update: Extract customized names from 'Experiment Variant Name(s)' in page metadata (#41)
5f942a2 feat: Add decoration handler for handling fragment decoration (#39)
9b4478d feat: Central host UI files (#40)

git-subtree-dir: plugins/experimentation
git-subtree-split: 942948d6334265d74d2bfa1342ec015a4c0c64ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandepass dylandepass dylandepass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Featured Article component does not pull title and description from the referenced article
2 participants
@blefebvre @dylandepass