Skip to content

Commit

Permalink
[MRG] Pin numpy to <2 (#581)
Browse files Browse the repository at this point in the history
* Pin numpy to <2

* Fix python 3.7 build

* Build for macos-13

* pin numpy during upgrade

* debug

* use windows-2019

* Try pinning cibuildwheel

* fix pin

* Don't test numpy upgrade

* Back to windows-latest
  • Loading branch information
aaronreidsmith authored Sep 24, 2024
1 parent c33a017 commit 11e5708
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/build_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ jobs:
strategy:
matrix:
python3-minor-version: [7, 8, 9, 10, 11, 12]
os: [macos-latest, ubuntu-latest, windows-latest]
# TODO: Figure out macos-14/macos-latest
os: [macos-13, ubuntu-latest, windows-latest]
defaults:
run:
shell: bash
Expand Down Expand Up @@ -54,7 +55,7 @@ jobs:
run: make version sdist

- name: Install cibuildwheel
run: python -m pip install cibuildwheel
run: python -m pip install 'cibuildwheel<2.20.0'

- name: Building and testing wheels
run: python -m cibuildwheel --output-dir dist
Expand All @@ -79,9 +80,10 @@ jobs:
CIBW_SKIP: "pp* *-musllinux_*"
# Runs tests and checks for a numpy regression by upgrading numpy and running tests again
CIBW_TEST_COMMAND: >
pytest --showlocals --durations=20 --pyargs pmdarima &&
pip install --upgrade scipy numpy &&
pytest --showlocals --durations=20 --pyargs pmdarima
# TODO: Add these back
# pip install --upgrade scipy numpy &&
# pytest --showlocals --durations=20 --pyargs pmdarima
# Avoid testing on emulated architectures
CIBW_TEST_SKIP: "*-*linux_{aarch64,ppc64le,s390x} *-macosx_arm64"

Expand Down
5 changes: 5 additions & 0 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ What's new in pmdarima
As new releases of pmdarima are pushed out, the following list (introduced in
v0.8.1) will document the latest features.

`v2.0.4 <https://alkaline-ml.com/pmdarima/2.0.4>`_
-------------------------------------------------

* Pin numpy to ``<2.0.0`` while work is done to support numpy ``>=2.0.0``

`v2.0.3 <https://alkaline-ml.com/pmdarima/2.0.3>`_
-------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
joblib>=0.11
Cython>=0.29,!=0.29.18,!=0.29.31
numpy>=1.21.2
numpy>=1.21.2,<2.0.0
pandas>=0.19
scikit-learn>=0.22
scipy>=1.3.2
Expand Down

0 comments on commit 11e5708

Please sign in to comment.