Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Pin numpy to <2 #581

Merged
merged 10 commits into from
Sep 24, 2024
Merged

[MRG] Pin numpy to <2 #581

merged 10 commits into from
Sep 24, 2024

Conversation

aaronreidsmith
Copy link
Member

Description

Pin numpy to <2.0.0 to buy more time on #578

Fixes #579

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tests pass

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith changed the title [WIP] Pin numpy to <2 [MRG] Pin numpy to <2 Aug 19, 2024
@aaronreidsmith aaronreidsmith merged commit 11e5708 into master Sep 24, 2024
29 checks passed
@aaronreidsmith aaronreidsmith deleted the pin-numpy branch September 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgsmith61591 tgsmith61591 tgsmith61591 approved these changes

@charlesdrotar charlesdrotar Awaiting requested review from charlesdrotar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding bounds for numpy in the build requirements and Adding version for build from source
2 participants
@aaronreidsmith @tgsmith61591