-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump govuk-frontend from 5.0.0 to 5.1.0 #3525
Bump govuk-frontend from 5.0.0 to 5.1.0 #3525
Conversation
Bumps [govuk-frontend](https://github.com/alphagov/govuk-frontend) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/alphagov/govuk-frontend/releases) - [Changelog](https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk-frontend@v5.0.0...v5.1.0) --- updated-dependencies: - dependency-name: govuk-frontend dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
8d2851f
to
aa2eaf9
Compare
@owenatgov @querkmachine I've added some fixes:
Can drop or revert 2) as necessary, but means we can merge this PR ahead of potential new guidance |
aa2eaf9
to
1ac63b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change prevents the new crown image assets being copied from v5.1.0+ and leaves Metalsmith to copy committed v5.0.0 assets from `src/assets` instead 1. Use `/assets/images` for new crown 2. Use `/assets/v5.0.0/images` for old crown
For example, we should never match Tab item `label` text
Unlike other components, hint or labels have no separate guidance pages Additionally, since child option slugs are suffixed with their parent we must use the original `id` when checking for hints or labels
1ac63b6
to
28cce47
Compare
Thanks @querkmachine, both consolidated into b4c8440 now Good to merge? |
@colinrotherham Go for it! |
Bumps govuk-frontend from 5.0.0 to 5.1.0.
Release notes
Sourced from govuk-frontend's releases.
... (truncated)
Changelog
Sourced from govuk-frontend's changelog.
... (truncated)
Commits
eb8b345
Merge pull request #4734 from alphagov/release-5.1.03ee36fd
Release v5.1.0876a4b8
Merge pull request #4721 from alphagov/querkmachine-patch-16fa2b67
Fix broken team docs link18cc100
Merge pull request #4693 from alphagov/dependabot/npm_and_yarn/test-80503005ef7bf27e6
Merge pull request #4713 from alphagov/deprecate-14-stringsffbfd86
Update changelog entry220a4c0
Remove duplicate font declarations for point 1402f5803
Add new$size-internal-use-only
for deprecated font sizes1ed26b0
Ensuregovuk-font-size()
handles string keysDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions