-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Tudor crown on website #3556
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
912fbb0
to
291ed70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owenatgov To undo the temporary assets, could you revert b4c8440 instead?
It was a request from @querkmachine that we use a single commit in #3525 (review)
It was my figuring that f0ecf75 is a reversion commit, it just doesn't mention such in the commit message. If we'd prefer that to be more explicit then it would just be a quick amend methinks? |
…rown" This reverts commit b4c8440.
291ed70
to
5d12808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Do we need to document the reverse?
Using useTudorCrown: false
for the legacy header
Probably not. There's not really any probable use case for it unless someone's trying to make a period drama featuring the GOV.UK website. |
5d12808
to
b50f4d5
Compare
It's crown day and gov.uk have just updated their logo so I'll be merging this imminently. Following a chat with the devs, I've dropped the commit which removes |
What
Does the following:
useTudorCrown
from the examples on the header page added in Add Tudor Crown update instructions to Header guidance #3533Why
We're planning on releasing govuk-frontend 5.2.0 on February 23rd, which is past the crown rollout embargo and a change which will turn on the tudor crown by default. This PR is in anticipation of the 5.2 release.
Extra thoughts
We could release this before 5.2, on the 19th or in the week, and split the header example changes into a different PR. I think my preference is still a single PR but I'm interested what others think.
This PR doesn't remove this section of the header page on the new crown rollout. My preference would be to keep this content around until after March 1st so that we're still advising teams managing their upgrade, but again I'm interested what others think.