Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tudor crown on website #3556

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Use Tudor crown on website #3556

merged 2 commits into from
Feb 19, 2024

Conversation

owenatgov
Copy link
Contributor

What

Does the following:

Why

We're planning on releasing govuk-frontend 5.2.0 on February 23rd, which is past the crown rollout embargo and a change which will turn on the tudor crown by default. This PR is in anticipation of the 5.2 release.

Extra thoughts

We could release this before 5.2, on the 19th or in the week, and split the header example changes into a different PR. I think my preference is still a single PR but I'm interested what others think.

This PR doesn't remove this section of the header page on the new crown rollout. My preference would be to keep this content around until after March 1st so that we're still advising teams managing their upgrade, but again I'm interested what others think.

@owenatgov owenatgov added this to the v5.2 milestone Feb 13, 2024
Copy link

netlify bot commented Feb 13, 2024

You can preview this change here:

Name Link
🔨 Latest commit b50f4d5
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/65d34079d18a4f0008707c9d
😎 Deploy Preview https://deploy-preview-3556--govuk-design-system-preview.netlify.app/components/header
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owenatgov To undo the temporary assets, could you revert b4c8440 instead?

It was a request from @querkmachine that we use a single commit in #3525 (review)

lib/metalsmith.js Outdated Show resolved Hide resolved
@querkmachine
Copy link
Member

It was my figuring that f0ecf75 is a reversion commit, it just doesn't mention such in the commit message.

If we'd prefer that to be more explicit then it would just be a quick amend methinks?

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Do we need to document the reverse?

Using useTudorCrown: false for the legacy header

@querkmachine
Copy link
Member

Do we need to document the reverse?

Using useTudorCrown: false for the legacy header

Probably not. There's not really any probable use case for it unless someone's trying to make a period drama featuring the GOV.UK website.

@owenatgov owenatgov changed the title [DO NOT MERGE (yet)] Use Tudor crown on website Use Tudor crown on website Feb 19, 2024
@owenatgov
Copy link
Contributor Author

It's crown day and gov.uk have just updated their logo so I'll be merging this imminently. Following a chat with the devs, I've dropped the commit which removes useTudorCrown from the header examples so that users can copy the correct crown in the update period.

@owenatgov owenatgov merged commit 7062372 into main Feb 19, 2024
13 checks passed
@owenatgov owenatgov deleted the use-tudor-crown branch February 19, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants