IAM user secret bugfixes #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuJo
force-pushed
the
iam_user_secret
branch
3 times, most recently
from
aba6cc6
to
e24bc88
Compare
* The web console has been moved to a separate port * Newer minio returns slightly differently formatted JSON, adapt tests to use a more complicated deep equals where needed.
* Revise test (which disabled the user itself instead of testing the implementation) * Use madmin AccountEnabled/Disabled instead of replicating the underlying strings * Make disabling users on creation possible, not only update * Only set user status on server if necessary
* As every usage is basically as a string, already handle the conversion in the utility function * Remove unused `must` variant * Check the error path, in case a random access key could not be generated
* Add test which actually changes the access key * Add a way to test user login without touching s3/admin commands, as those already need policies/permissions. This is handled via the built-in minio UI. See code comments for more information.
* The secret had not been marked as editable, although the rest of the code had been prepared for secrets to be configurable from outside. * Add missing test to actually prevent this feature from breaking.
* Assumes the console port to be 9001
BuJo
force-pushed
the
iam_user_secret
branch
from
e24bc88
to
1286ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves How can I change user secret or rotate it in the right way? #119
Resolves How can I change user secret or rotate it in the right way? #119