Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAM user secret bugfixes #141

Merged
merged 12 commits into from
Feb 11, 2022
Merged

IAM user secret bugfixes #141

merged 12 commits into from
Feb 11, 2022

Commits on Feb 11, 2022

  1. docker-compose, update minio release 

    * The web console has been moved to a separate port
* Newer minio returns slightly differently formatted JSON,
  adapt tests to use a more complicated deep equals where
  needed.
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e671bd5 View commit details
    Browse the repository at this point in the history

  2. iam_user, make secret sensitive

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    520e1a5 View commit details
    Browse the repository at this point in the history

  3. iam_user, fix creating users in disabled state 

    * Revise test (which disabled the user itself instead of testing the
  implementation)
* Use madmin AccountEnabled/Disabled instead of replicating the underlying
  strings
* Make disabling users on creation possible, not only update
* Only set user status on server if necessary
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e5c2443 View commit details
    Browse the repository at this point in the history

  4. iam_user, revise api for generating secret access keys 

    * As every usage is basically as a string, already handle the
  conversion in the utility function
* Remove unused `must` variant
* Check the error path, in case a random access key could not be
  generated
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    5e9e763 View commit details
    Browse the repository at this point in the history

  5. iam_user, on user creation, only use random accessKey if none given

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    5ed2f80 View commit details
    Browse the repository at this point in the history

  6. iam_user, make sure to record changing the secret key on user updates

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    0fd21dd View commit details
    Browse the repository at this point in the history

  7. iam_user, use explicit login check instead of setting user data

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    c42ae1a View commit details
    Browse the repository at this point in the history

  8. iam_user, actually check that a newly created user can log in 

    * Add test which actually changes the access key
* Add a way to test user login without touching s3/admin commands,
  as those already need policies/permissions.
  This is handled via the built-in minio UI.
  See code comments for more information.
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    daf2ba0 View commit details
    Browse the repository at this point in the history

  9. iam_user, revise naming of test methods for rotating access keys

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    2cafe3b View commit details
    Browse the repository at this point in the history

  10. iam_user, actually make user secrets configurable 

    * The secret had not been marked as editable, although the rest of
  the code had been prepared for secrets to be configurable from outside.
* Add missing test to actually prevent this feature from breaking.
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    bd51e9d View commit details
    Browse the repository at this point in the history

  11. iam_user, fix codestyle regarding unhandled error in defer

    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    83018cf View commit details
    Browse the repository at this point in the history

  12. iam_user, adapt login check for new minio versions 

    * Assumes the console port to be 9001
    @BuJo
    BuJo committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    1286ae0 View commit details
    Browse the repository at this point in the history