Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to minio_s3_bucket_versioning #379

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

pjsier
Copy link
Collaborator

@pjsier pjsier commented Oct 29, 2022

Adds exclude_folders and excluded_prefixes fields to minio_s3_bucket_versioning resource to cover missing functionality. Initially I'd planned on including mfa_delete as well because it's in the client, but after some initial troubleshooting it looks like it isn't currently supported on the server:

https://github.com/minio/minio/blob/52221db7ef4944fa0a2e0b133c760687ca8fe66e/internal/bucket/versioning/versioning.go#L53

The other fields look like they're working fine though, but wanted to flag that

Reference

Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, @pjsier!
Tested and working as described!

In a follow-up PR we can add an example using excluded_prefixes and exclude_folders in examples/bucket/bucket.tf.

@felladrin felladrin merged commit 1767110 into aminueza:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more fields to minio_s3_bucket_versioning
2 participants