fix: add status code check to response handlers (#351)

amplitude · Feb 8, 2023 · af9f4f1 · af9f4f1
1 parent 19f6f5d
commit af9f4f1
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/main/java/com/amplitude/api/AmplitudeClient.java b/src/main/java/com/amplitude/api/AmplitudeClient.java
@@ -2271,7 +2271,7 @@ protected void makeEventUploadPostRequest(Call.Factory client, String events, fi
         try {
             Response response = client.newCall(request).execute();
             String stringResponse = response.body().string();
-            if (response.code() == 200 || stringResponse.equals("success")) {
+            if (response.code() == 200) {
                 uploadSuccess = true;
                 logThread.post(new Runnable() {
                     @Override
@@ -2293,14 +2293,11 @@ public void run() {
                         }
                     }
                 });
-            } else if (stringResponse.equals("invalid_api_key")) {
+            } else if (response.code() == 400 && stringResponse.equals("invalid_api_key")) {
                 logger.e(TAG, "Invalid API key, make sure your API key is correct in initialize()");
-            } else if (stringResponse.equals("bad_checksum")) {
+            } else if (response.code() == 400 && stringResponse.equals("bad_checksum")) {
                 logger.w(TAG,
                         "Bad checksum, post request was mangled in transit, will attempt to reupload later");
-            } else if (stringResponse.equals("request_db_write_failed")) {
-                logger.w(TAG,
-                        "Couldn't write to request database on server, will attempt to reupload later");
             } else if (response.code() == 413) {
 
                 // If blocked by one massive event, drop it