Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/chips): selectable="false" doesn't work on initial assignment #24906

Merged

Conversation

volvachev
Copy link
Contributor

Fixes #24903.

@andrewseguin
Copy link
Contributor

Can you write tests for this case, and include the tests in the MDC version?

@volvachev volvachev force-pushed the fix-chiplist-with-initial-selectable-property branch from a5c8d57 to ca2ce61 Compare June 25, 2022 08:00
@volvachev volvachev requested a review from mmalerba as a code owner June 25, 2022 08:00
@volvachev volvachev force-pushed the fix-chiplist-with-initial-selectable-property branch 2 times, most recently from 8ef8335 to 19af7ae Compare June 25, 2022 13:41
@andrewseguin andrewseguin self-assigned this Jun 27, 2022
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 27, 2022
@mmalerba mmalerba force-pushed the fix-chiplist-with-initial-selectable-property branch from 19af7ae to 1d19c08 Compare August 9, 2022 16:37
@mmalerba mmalerba merged commit 1d1247c into angular:main Aug 10, 2022
mmalerba pushed a commit that referenced this pull request Aug 10, 2022
mmalerba pushed a commit that referenced this pull request Aug 10, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 12, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.1/14.1.2) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.1/14.1.2) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.1.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1412-cedar-cicada-2022-08-11)

[Compare Source](angular/components@14.1.1...14.1.2)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [69b29046d5](angular/components@69b2904) | fix | **chips:** `selectable="false"` doesn't work on initial assignment ([#&#8203;24906](angular/components#24906)) |
| [0f2ec70c86](angular/components@0f2ec70) | fix | **tooltip:** avoid problem when triggers hide animation for not visible tooltip ([#&#8203;24652](angular/components#24652)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [0a4d8e9fc4](angular/components@0a4d8e9) | fix | **mdc-list:** set a role on MatNavList and MatActionList ([#&#8203;25412](angular/components#25412)) |

#### Special Thanks

Egor Volvachev, Miles Malerba, Wagner Maciel and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuNyIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC43In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1503
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-chip-list): selectable="false" doesn't work on initial assignment
3 participants