Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-list): set a role on MatNavList and Mat… #25412

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix(material-experimental/mdc-list): set a role on MatNavList and Mat… #25412

merged 1 commit into from
Aug 10, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Aug 8, 2022

…ActionList

make the following changes to align with legacy version of list

  • MatNavList apply role="navigation"
  • MatActionList apply role="group"

@zarend zarend added Accessibility This issue is related to accessibility (a11y) area: material/list labels Aug 8, 2022
@zarend
Copy link
Contributor Author

zarend commented Aug 8, 2022

Is there a requirement that the developer needs to be able to explicitly set the role?

crisbeto
crisbeto approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add a couple of simple unit tests for it?

@zarend
Copy link
Contributor Author

zarend commented Aug 9, 2022

LGTM. Should we add a couple of simple unit tests for it?

sg, I added unit tests to both MDC list and material/list.

@zarend
fix(material-experimental/mdc-list): set a role on MatNavList and Mat…
47bbe92 
…ActionList

make the following changes to align with legacy version of list
 - `MatNavList` apply `role="navigation"`
 - `MatActionList` apply `role="group"`
devversion
devversion approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like this would override existing role's applied by users, but sounds like we could land this as a "fix"

@zarend zarend added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Aug 9, 2022
@zarend zarend merged commit dd1bfad into angular:main Aug 10, 2022
zarend added a commit that referenced this pull request Aug 10, 2022
@zarend
fix(material-experimental/mdc-list): set a role on MatNavList and Mat…
7c0f563 
…ActionList (#25412)

make the following changes to align with legacy version of list
 - `MatNavList` apply `role="navigation"`
 - `MatActionList` apply `role="group"`

(cherry picked from commit dd1bfad)
zarend added a commit that referenced this pull request Aug 10, 2022
@zarend
fix(material-experimental/mdc-list): set a role on MatNavList and Mat…
0a4d8e9 
…ActionList (#25412)

make the following changes to align with legacy version of list
 - `MatNavList` apply `role="navigation"`
 - `MatActionList` apply `role="group"`

(cherry picked from commit dd1bfad)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 12, 2022
Update angularmaterial monorepo to v14.1.2 (#1503)
576ad47 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.1/14.1.2) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.1/14.1.2) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.1.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1412-cedar-cicada-2022-08-11)

[Compare Source](angular/components@14.1.1...14.1.2)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [69b29046d5](angular/components@69b2904) | fix | **chips:** `selectable="false"` doesn't work on initial assignment ([#&#8203;24906](angular/components#24906)) |
| [0f2ec70c86](angular/components@0f2ec70) | fix | **tooltip:** avoid problem when triggers hide animation for not visible tooltip ([#&#8203;24652](angular/components#24652)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [0a4d8e9fc4](angular/components@0a4d8e9) | fix | **mdc-list:** set a role on MatNavList and MatActionList ([#&#8203;25412](angular/components#25412)) |

#### Special Thanks

Egor Volvachev, Miles Malerba, Wagner Maciel and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuNyIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC43In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1503
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 16, 2022
Closed
This was referenced Aug 23, 2022
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 1, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/list target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zarend @crisbeto @devversion @mmalerba