fix(cdk-experimental/listbox): fix issue with aria-selected #25373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
action: merge
mmalerba
added a commit
that referenced
this pull request
Aug 2, 2022
(cherry picked from commit e22e9f5)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Sep 1, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.3/14.2.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.3/14.2.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1420-rayon-river-2022-08-25) [Compare Source](angular/components@14.1.3...14.2.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [06c2164618](angular/components@06c2164) | feat | **a11y:** add named export and public property to CdkMonitorFocus directive ([#​25427](angular/components#25427)) | | [0fb2e9a5f7](angular/components@0fb2e9a) | feat | **listbox:** add listbox to cdk ([#​25380](angular/components#25380)) ([#​25474](angular/components#25474)) | | [79858ea14b](angular/components@79858ea) | fix | **scrolling:** error during server-side rendering ([#​25461](angular/components#25461)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [657774e29b](angular/components@657774e) | feat | **datepicker:** Allow user to jump between start and end dates with arrow keys ([#​25359](angular/components#25359)) | ##### cdk-experimental | Commit | Type | Description | | -- | -- | -- | | [aaa9d93c92](angular/components@aaa9d93) | fix | **listbox:** fix issue with aria-selected ([#​25373](angular/components#25373)) | #### Special Thanks Andrew Seguin, Emmanuel Roux, Joey Perrott, Karl Seamon, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ny4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1522 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the aria-selected issue was because it wants the
aria-selectedattribute explicitly set, the absence of the attribute was being treated as selected.For the home/end issue with voiceover, it seems to be just how voiceover works. I found the same behavior for the list and the MDC-based list. I think voiceover just has its own binding for home/end, and using preventDefault doesn't seem to stop it. If I do ctrl+option+{home/end} it seems to work as expected