Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/scrolling): error during server-side rendering #25461

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

crisbeto
Copy link
Member

Fixes that an error was being thrown by the virtual scroller during server-side rendering. It wasn't failing the SSR check, because the error happens inside of a promise callback.

Fixes that an error was being thrown by the virtual scroller during server-side rendering. It wasn't failing the SSR check, because the error happens inside of a promise callback.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 13, 2022
@crisbeto crisbeto requested a review from mmalerba August 19, 2022 20:51
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 19, 2022
@amysorto amysorto merged commit d9e96ff into angular:main Aug 23, 2022
amysorto pushed a commit that referenced this pull request Aug 23, 2022
Fixes that an error was being thrown by the virtual scroller during server-side rendering. It wasn't failing the SSR check, because the error happens inside of a promise callback.

(cherry picked from commit d9e96ff)
amysorto pushed a commit that referenced this pull request Aug 23, 2022
Fixes that an error was being thrown by the virtual scroller during server-side rendering. It wasn't failing the SSR check, because the error happens inside of a promise callback.

(cherry picked from commit d9e96ff)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.3/14.2.0) |
| [@angular/material](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.3/14.2.0) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1420-rayon-river-2022-08-25)

[Compare Source](angular/components@14.1.3...14.2.0)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [06c2164618](angular/components@06c2164) | feat | **a11y:** add named export and public property to CdkMonitorFocus directive ([#&#8203;25427](angular/components#25427)) |
| [0fb2e9a5f7](angular/components@0fb2e9a) | feat | **listbox:** add listbox to cdk ([#&#8203;25380](angular/components#25380)) ([#&#8203;25474](angular/components#25474)) |
| [79858ea14b](angular/components@79858ea) | fix | **scrolling:** error during server-side rendering ([#&#8203;25461](angular/components#25461)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [657774e29b](angular/components@657774e) | feat | **datepicker:** Allow user to jump between start and end dates with arrow keys ([#&#8203;25359](angular/components#25359)) |

##### cdk-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [aaa9d93c92](angular/components@aaa9d93) | fix | **listbox:** fix issue with aria-selected ([#&#8203;25373](angular/components#25373)) |

#### Special Thanks

Andrew Seguin, Emmanuel Roux, Joey Perrott, Karl Seamon, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ny4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1522
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants