Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

document app.css #19

Closed
lookfirst opened this issue Mar 16, 2015 · 2 comments
Closed

document app.css #19

lookfirst opened this issue Mar 16, 2015 · 2 comments

Comments

@lookfirst
Copy link

https://github.com/angular/material-start/blob/master/app/assets/app.css

Where did this file come from?
How does it apply to material design?
Why does it seem to be so responsible for the look and feel?
Why isn't it scss?

I guess my confusion is more around why this isn't just part of angular/bower-material/angular-material.css? It doesn't feel very re-usable and feels kind of hidden in this starter project.

@marcysutton
Copy link

I think there are quite a few styles in there that can be removed once angular/material#1985 is merged. But I think the general idea is that you should have a file with your specific overrides in it. If there are that many look-and-feel styles in app.css even when angular-material.css is included, it points out holes in our CSS API.

@lookfirst
Copy link
Author

Just commenting out the app.css, it feels like there is quite a bit of style being declared that is helpful at a framework level.

screenshots: http://take.ms/b9oDT vs. http://take.ms/X7Ivw

topherfangio pushed a commit that referenced this issue Sep 9, 2016
topherfangio added a commit that referenced this issue Sep 9, 2016
* Update README for tutorials and UX snapshots.

* Edit of branch options

* Update README.md

* readme updates

* README improvemens.

* Fix package.json format

Closes #12

* update(sidenav) - sidenav display now hides bottomsheet (if open).

[Material SHA 690aa87](angular/material@690aa87) fixes backdrop containment and animations of bottomsheet.

* remove orphaned closure va

* Configure e2e setups and tests

Improve the README and project setup files to get Protractor running with the accessibility plugin, and includes two working tests.

Closes #37

* Adding line breaks to make README more readable

* Fixing list numbering in README

* Update README.md

* Update README.md

* Naming and e2e testing improvements

* fix(e2e): refactor tests and fix expects() on bottomSheets.

* fix(e23): disable animations for tests

* fix(e23): disable animations for tests

* update(e2e): allow animations, remove sleep() calls.

* update(e2e): add sleep() to resolve $animate bugs

* update(html): fix use of toolbars and shadows.

* Cleaning up config

* update(package.json): remove unneeded ./node_modules/.bin prefix.

Closes #40.

* update(readme): typo fix and link

Remove ref to es6-tutorial (until published).

Closes #5. Closes #8. Closes #16.

* update(bottomsheet): fix url to bottomsheet template

Closes #21. Fixes #18.

* update(readme): typos

Closes #32. Closes #34.
s

* Update README.md

* update(build): use bower-material HEAD and Angualr v1.4.6

* update(html): use ng-cloak to hide UI until bootstrapping is done

* Update README.md

* Update README.md

* Update README.md

* add instructions to install live-server using npm

* update(package.json): add MIT licenses metadata

* update(app): sync features with es5 tutorial

* update(readme): update install directions

Closes #61.

* update(readme): fix typos

Closes #52. Closes #59.

* update(css): clean app.css

Fixes #19.

* update(css): fix avatar styles

Fixes #45.

* update(build): fix karma and npm packages

*  update package.json
*  remove use of `bower`; only use npm
*  add karma unit tests, fix karma.conf.js
*  remove protractor configuration; disabled for now.

Fixes #55. Fixes #51. Fixes #44. Fixes #23.

* update(build): centralize test configuration files

* fix(demo): contact sheet click handler to close

Fixes #93.

* update(packages.json): update Angular dependencies

* added jasmine-core to devDependencies; Thx @thomasrehm

Closes #94.

* update(app): sync with final es5-tutorial version

* update(npm): install angular-material using https

* update(npm): disable Karma tests

This repository is purposed to show solutions and tutorials for using
Angular Material. It is not purposed to show solutions for Jasmine/Karma
testing of ES5 or ES6 Angular SPAs.

* fix(npm): fix script section

Closes #132

* Update README.md

* Update README.md

* docs(README): remove references to the UI tests

* Remove $scope from selectUser function in UserController (#141)

* Converting 'git+ssh' dependency to 'npm' dependency. It fixed 'npm install' error on my machine.

* Update README to reflect upcoming repository (ES6) changes and fix a few typos/issues.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants