CSS Refactor: Minimize global styles, support high contrast mode, new typography feature #1985
Conversation
ajoslin
added
the
in progress
| @return $map-str + '}'; | ||
| } | ||
|
|
||
| @function map-to-string($map) { |
There was a problem hiding this comment.
Isn't this exactly the same as the above function ?
There was a problem hiding this comment.
Git rebase mixup, good catch!
|
After a superficial look, this looks nice. |
Plus CSS cleanup and comments Closes #1989
marcysutton
added
resolution: fixed
and removed
in progress
| font-size: 100%; | ||
| } | ||
|
|
||
| ul { |
There was a problem hiding this comment.
Why is this in the typography SASS ?
There was a problem hiding this comment.
The goal is to provide basic typographic defaults for the framework. Do you mean the list styles? They could be moved back to structure.scss I suppose, but I thought they were related to typography. Or do you think we shouldn't include global styles for lists?
There was a problem hiding this comment.
I think we should keep the typography.scss consistent. Let's move the ul styling to structure.scss.
There was a problem hiding this comment.
Already done actually. I think I'll have the Typography page done today, and that change is in there. I can even commit it as part of this PR.
Includes:
layout.scssin Safaritext-renderingto specific elements concerned with typographyCloses #1442, #1561, #1128, #1989, Refs #1718