Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

What is the distinction between docs and core? #1718

Closed
DavidSouther opened this issue Feb 28, 2015 · 2 comments
Closed

What is the distinction between docs and core? #1718

DavidSouther opened this issue Feb 28, 2015 · 2 comments
Assignees
Milestone

Comments

@DavidSouther
Copy link

For instance, when using md-toolbar with an h2 class md-toolbar-tools, I expect my code to look "exactly" like the demo. However, the 16px padding left on h2.md-toolbar-tools is in the docs.css, not a part of the core. As a user, I expect the demos to be copy/paste and "just work"; instead, I need to dig into the docs.css to get the same visual styles.

Please add (or point me to) a task that covers untangling these on the release milestones. Thank you!

(PS I love watching the features as they keep rolling in!)

@ThomasBurleson
Copy link
Contributor

Related to #594

@ThomasBurleson ThomasBurleson added this to the 0.9.0 milestone Feb 28, 2015
@marcysutton marcysutton self-assigned this Mar 13, 2015
@marcysutton
Copy link
Contributor

The CSS API (#594) and Typography defaults in #1128 will definitely help this.

However, I looked at the docs CSS file (docs/app/css/style.css) to make sure there weren't any styles included that should have been in toolbar.scss or elsewhere. There are some changes coming for this, but I found that there were no padding styles for .md-toolbar-tools in the docs CSS. Rather, you are seeing that the docs build system packages Angular Material along with the docs CSS, so in the browser it looks like the styles are attributed to the docs CSS, rather than the framework. @ThomasBurleson I bet it would help to separate docs.css from angular-material.css in our build system to clarify where the styles are coming from.

In any case, I'm working on the toolbar style defaults so that they work with headings out of the box, as I ran into the same issue when I created the Hello World Codepen.

marcysutton pushed a commit that referenced this issue Mar 14, 2015
Includes new typography stylesheet, flex styles for layout.scss in Safari

Closes #1442, #1561, #1718
marcysutton pushed a commit that referenced this issue Mar 18, 2015
Includes new typography stylesheet, flex styles for layout.scss in Safari

Closes #1442, #1561, #1718
marcysutton pushed a commit that referenced this issue Mar 18, 2015
Includes new typography stylesheet, flex styles for layout.scss in Safari

Closes #1442, #1561, #1718
marcysutton pushed a commit that referenced this issue Mar 20, 2015
Includes new typography stylesheet, flex styles for layout.scss in Safari

Closes #1442, #1561, #1718
marcysutton pushed a commit that referenced this issue Mar 27, 2015
Includes new typography stylesheet, flex styles for layout.scss in Safari

Closes #1442, #1561, #1718
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants