Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-secondary button on md-list-item is broken #3176

Closed
wlingke opened this issue Jun 8, 2015 · 3 comments
Closed

md-secondary button on md-list-item is broken #3176

wlingke opened this issue Jun 8, 2015 · 3 comments
Assignees
@topherfangio
Milestone
1.0-rc5

Comments

@wlingke
Copy link

wlingke commented Jun 8, 2015

Theres two related issues on md-secondary md-button in md-list-item:

  1. If you add md-secondary md-button on a ng-clickable md-list-item, button alignment is slightly off. Also if you click on the button, it also "clicks" on the list-item
  2. If you add md-secondary md-button (or md-icon) on a NON-clickable md-list-item, the button alignment is completely off

http://codepen.io/anon/pen/yNaKbK
@wlingke wlingke changed the title md-secondary without ng-click on md-list-item is broken md-secondary button on md-list-item is broken Jun 8, 2015
@mukilane mukilane mentioned this issue Jun 19, 2015
Closed
@ThomasBurleson ThomasBurleson self-assigned this Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 0.12.0 Sep 2, 2015
@topherfangio topherfangio mentioned this issue Sep 4, 2015
Closed
@epelc
Copy link
Contributor

epelc commented Sep 15, 2015

+1 ran into this issue with 0.10.1 today.

@MichaelGofron
Copy link

+1 ran into this issue today as well

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc1, 1.0-rc2, 1.0-rc3 Oct 27, 2015
@topherfangio
Copy link
Contributor

Bumping priority and putting it in RC4.

@topherfangio topherfangio modified the milestones: 1.0-rc4, 1.0-rc3 Nov 3, 2015
topherfangio added a commit that referenced this issue Nov 13, 2015
@topherfangio
fix(list): Don't wrap secondary buttons in a button.
d3c40b6 
We currently wrap many `.md-secondary` items in an extra button
for accessibility purposes. However, there is no need to wrap an
existing button inside an additional one as it creates odd
behavior and styling.

Additionally, fix some styles so that secondary buttons render
properly (position was off due to margins).

Lastly, add some new demo code to show how to use this functionality.

Fixes #3176.
@topherfangio topherfangio mentioned this issue Nov 13, 2015
Closed
@topherfangio topherfangio modified the milestones: 1.0-rc5, 1.0-rc4 Nov 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
None yet
Projects
None yet
Milestone
1.0-rc5
Development

Successfully merging a pull request may close this issue.

fix(list): Don't wrap secondary buttons in a button. angular/material
5 participants
@topherfangio @ThomasBurleson @wlingke @MichaelGofron @epelc