This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): Don't wrap secondary buttons in a button. #5721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently wrap many `.md-secondary` items in an extra button for accessibility purposes. However, there is no need to wrap an existing button inside an additional one as it creates odd behavior and styling. Additionally, fix some styles so that secondary buttons render properly (position was off due to margins). Lastly, add some new demo code to show how to use this functionality. Fixes #3176.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently wrap many
.md-secondaryitems in an extra button for accessibility purposes. However, there is no need to wrap an existing button inside an additional one as it creates odd behavior and styling.Additionally, fix some styles so that secondary buttons render properly (position was off due to margins).
Lastly, add some new demo code to show how to use this functionality.
Fixes #3176.