Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdAutocomplete: Progress bar is visible after clearing input when caching is turned on #8195

Closed
edbentinck opened this issue Apr 24, 2016 · 0 comments
Closed

mdAutocomplete: Progress bar is visible after clearing input when caching is turned on #8195

edbentinck opened this issue Apr 24, 2016 · 0 comments
Assignees
@crisbeto
Labels
has: Pull Request A PR has been created to address this issue

Comments

@edbentinck
Copy link

edbentinck commented Apr 24, 2016 •
edited
Loading

Since v1.0.7 a bug was introduced whereby the loading bar is incorrectly visible after clearing the search input when caching is turned on.

NB: This is similar, but not identical, to issue #7927

Here is a codepen based on the demo code from v1.0.7.

Steps to recreate the bug:

  • Type 'a' into the input (notice that caching is turned on)
  • Click the close icon ('x') inside the input

You'll see that the loading bar is activated, but never goes away.
@edbentinck edbentinck changed the title mdAutocomplete: Progress bar is visible after clearing input when cache is turned off mdAutocomplete: Progress bar is visible after clearing input when caching is turned on Apr 25, 2016
@ThomasBurleson ThomasBurleson added this to the - Backlog milestone Apr 25, 2016
@RolandHeath RolandHeath mentioned this issue May 3, 2016
Closed
crisbeto added a commit to crisbeto/material that referenced this issue May 4, 2016
@crisbeto
fix(autocomplete): always hide the progressbar when clearing the input
fbff3d0 
The autocomplete was showing the loading bar "so we don't see flashes of content", however this causes the progress to show up in random and unexpected scenarios. This change switches it so it always gets hidden when the input is cleared.

Fixes angular#8301, angular#8195.
@crisbeto crisbeto mentioned this issue May 4, 2016
Closed
@devversion devversion added the has: Pull Request A PR has been created to address this issue label May 5, 2016
crisbeto added a commit to crisbeto/material that referenced this issue May 5, 2016
@crisbeto
fix(autocomplete): always hide the progressbar when clearing the input
29e620a 
Fixes angular#8301, angular#8195.
ThomasBurleson pushed a commit that referenced this issue May 30, 2016
@crisbeto @ThomasBurleson
fix(autocomplete): always hide the progressbar when clearing the input
3b3fc39 
Fixes #8301, #8195.

Closes #8341
@crisbeto crisbeto closed this as completed Jun 1, 2016
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
has: Pull Request A PR has been created to address this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ThomasBurleson @Splaktar @crisbeto @devversion @edbentinck