This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): always hide the progressbar when clearing the input #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Set the loading to true so we don't see flashes of content. | ||
| // The flashing will only occour when an async request is running. | ||
| // So the loading process will stop when the results had been retrieved. | ||
| setLoading(true); |
There was a problem hiding this comment.
@crisbeto Those flashes are appearing, when asynchronously querying. I actually wasn't the guy who introduced this fix, but it seems reasonable for me.
We should keep that, and set the loading to false, once the results are fetched successfully.
Everything works fine, when caching is disabled, so the issue is, that we're resetting the loading, when the results were already cached.
To fix the issue, we simply need to reset the loading here
There was a problem hiding this comment.
Thank you, I'll rework it.
crisbeto
added
needs: work
and removed
needs: review
crisbeto
force-pushed
the
fix/autocomplete-progress-again
branch
from
fbff3d0
to
29e620a
Compare
crisbeto
added
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8301, #8195.