Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

list: restructure the component #8482

Open
crisbeto opened this issue May 17, 2016 · 5 comments
Open

list: restructure the component #8482

crisbeto opened this issue May 17, 2016 · 5 comments
Assignees
@Splaktar
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P3: important Important issues that really should be fixed when possible.
Milestone
- Backlog

Comments

@crisbeto
Copy link
Member

As discussed with @ThomasBurleson, we should try to simplify the list component at some point, because it shuffles the DOM a lot and is overly complicated. This can lead to issues like #6152 and #8172.
@crisbeto crisbeto added the P2: required Issues that must be fixed. label May 17, 2016
@crisbeto crisbeto added this to the - Backlog milestone May 17, 2016
@devversion
Copy link
Member

devversion commented May 17, 2016 •
edited
Loading

@crisbeto - Elad and I already worked on that.

We started with a design doc, but this refactoring was currently pushed back in the queue, because there were other priorities.

@crisbeto
Copy link
Member Author

Ah cool, is there an issue for it so I can reference it in the ones?

@devversion
Copy link
Member

There is no issue yet, so I think it's good to use your issue now.

@devversion devversion self-assigned this May 17, 2016
@ThomasBurleson ThomasBurleson modified the milestones: - Backlog, Deprecated May 26, 2016
@devversion devversion modified the milestones: - Backlog, Deprecated May 27, 2016
This was referenced Jun 6, 2016
Closed
Closed
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
8c3c3ce 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
d80ad21 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion mentioned this issue Jul 31, 2016
Merged
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
77ff050 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jul 31, 2016
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
8bc4021 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion mentioned this issue Aug 5, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Aug 5, 2016
@devversion
refactor(list): simplify list component scss
e87163b 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 5, 2016
@devversion
refactor(list): simplify list component scss
8369c2f 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 8, 2016
@devversion
refactor(list): simplify list component scss
203e2f8 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 29, 2016
@devversion
refactor(list): simplify list component scss
fa8529d 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
This was referenced Sep 8, 2016
Closed
Closed
devversion added a commit to devversion/material that referenced this issue Sep 19, 2016
@devversion
refactor(list): simplify list component scss
b410e20 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Oct 5, 2016
@devversion
refactor(list): simplify list component scss
36ce2f0 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion mentioned this issue Oct 8, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Oct 14, 2016
@devversion
refactor(list): simplify list component scss
545d706 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Dec 3, 2016
@devversion
refactor(list): simplify list component scss
c406c34 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Dec 3, 2016
@devversion
refactor(list): simplify list component scss
a4ff3c5 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
kara pushed a commit that referenced this issue Jan 4, 2017
@devversion @kara
refactor(list): simplify list component scss (#9194)
085c5fd 
Fixes #6152. Fixes #8890. References #8482.
davidenochk pushed a commit to davidenochk/material that referenced this issue Feb 3, 2017
@devversion
refactor(list): simplify list component scss (angular#9194)
c55f7d0 
Fixes angular#6152. Fixes angular#8890. References angular#8482.
@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Dec 9, 2018
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community and removed P2: required Issues that must be fixed. labels Dec 9, 2018
@Splaktar
Copy link
Member

Splaktar commented Dec 9, 2018

The CSS was simplified in PR #9194. It's not clear whether or not we still need to restructure the list component.

This issue only mentions that the list component

shuffles the DOM a lot and is overly complicated. This can lead to issues like #6152 and #8172.

Both of the referenced issues are closed, but it's not clear that the second is actually fixed.
I also do not currently have access to the design doc. I may be able to get access, but I'm not sure if it is still relevant.

I'll try to re-visit this when more of the P1, P2, and P3 issues are resolved.

@Splaktar Splaktar self-assigned this Dec 9, 2018
@Splaktar
Copy link
Member

It turns out that the CSS was not simplified as the previous PR was reverted in PR #10221 (before ever being released in 1.1.2).

Here's the status on the issues mentioned here:

@Splaktar Splaktar changed the title Restructure the list component list: restructure the component Sep 23, 2019
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. and removed P4: minor Minor issues. May not be fixed without community contributions. labels Sep 23, 2019
@Splaktar Splaktar mentioned this issue Sep 30, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P3: important Important issues that really should be fixed when possible.
Projects
None yet
Milestone
- Backlog
Development

No branches or pull requests
4 participants
@ThomasBurleson @Splaktar @crisbeto @devversion