Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

list: dense list cuts off some letters like 'g' #8890

Closed
lucasmaj opened this issue Jun 28, 2016 · 7 comments · Fixed by #9194 or #11806
Closed

list: dense list cuts off some letters like 'g' #8890

lucasmaj opened this issue Jun 28, 2016 · 7 comments · Fixed by #9194 or #11806
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed type: bug type: spec alignment For issues related to aligning with the Material Design Spec ui: CSS
Milestone
1.1.22

Comments

@lucasmaj
Copy link

Notice how 'g's get cutoff (at least latest Chrome and Firefox, Windows 10)

http://codepen.io/anon/pen/OXpQmV
@saleem-git
Copy link

+1

@ThomasBurleson
Copy link
Contributor

Unable to reproduce.

@lucasmaj
Copy link
Author

Screenshot from code pen http://codepen.io/anon/pen/OXpQmV
image

@lucasmaj
Copy link
Author

Thomas, I uploaded a screenshot. Please reopen.

On Mon, Jul 25, 2016 at 10:34 AM Thomas Burleson notifications@github.com
wrote:

Closed #8890 #8890.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8890 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD8FwGi_2vcda2N87QY7bFhitodXt-HEks5qZNd6gaJpZM4JAa7m
.

@devversion devversion reopened this Jul 31, 2016
@devversion
Copy link
Member

I can also reproduce this and a fix is in progress.

@devversion devversion self-assigned this Jul 31, 2016
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
8c3c3ce 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
d80ad21 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion mentioned this issue Jul 31, 2016
Merged
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
77ff050 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion added the has: Pull Request A PR has been created to address this issue label Jul 31, 2016
devversion added a commit to devversion/material that referenced this issue Jul 31, 2016
@devversion
refactor(list): simplify list component scss
8bc4021 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 5, 2016
@devversion
refactor(list): simplify list component scss
e87163b 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 5, 2016
@devversion
refactor(list): simplify list component scss
8369c2f 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Aug 8, 2016
@devversion
refactor(list): simplify list component scss
203e2f8 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@ThomasBurleson ThomasBurleson added this to the 1.2.0 milestone Aug 22, 2016
devversion added a commit to devversion/material that referenced this issue Aug 29, 2016
@devversion
refactor(list): simplify list component scss
fa8529d 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Sep 19, 2016
@devversion
refactor(list): simplify list component scss
b410e20 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@devversion devversion mentioned this issue Sep 30, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Oct 5, 2016
@devversion
refactor(list): simplify list component scss
36ce2f0 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Oct 14, 2016
@devversion
refactor(list): simplify list component scss
545d706 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Dec 3, 2016
@devversion
refactor(list): simplify list component scss
c406c34 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
devversion added a commit to devversion/material that referenced this issue Dec 3, 2016
@devversion
refactor(list): simplify list component scss
a4ff3c5 
* Simplifies the List components SCSS
* Fixes Dense Mode for List and introduces super elegant approach
* Make SCSS more modular by having a base and dynamic variables
* Remove unnecessary DOM node level for button wrap.
* No longer wrap proxied elements inside of buttons
* Multiple Secondary Items should align properly and have consistent spacing.
* Dense Mode should not cut characaters on different environments.

Fixes angular#6152. Fixes angular#8890 References angular#8482.
@kara kara closed this as completed in #9194 Jan 4, 2017
kara pushed a commit that referenced this issue Jan 4, 2017
@devversion @kara
refactor(list): simplify list component scss (#9194)
085c5fd 
Fixes #6152. Fixes #8890. References #8482.
davidenochk pushed a commit to davidenochk/material that referenced this issue Feb 3, 2017
@devversion
refactor(list): simplify list component scss (angular#9194)
c55f7d0 
Fixes angular#6152. Fixes angular#8890. References angular#8482.
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.2 Mar 1, 2018
@angular angular locked as resolved and limited conversation to collaborators Dec 9, 2018
@Splaktar Splaktar changed the title Dense mdList cuts off some letters like 'g' list: dense list cuts off some letters like 'g' Sep 23, 2019
@angular angular unlocked this conversation Sep 23, 2019
@Splaktar Splaktar modified the milestones: 1.1.2, 1.1.21 Sep 23, 2019
@Splaktar Splaktar added P2: required Issues that must be fixed. and removed has: Pull Request A PR has been created to address this issue resolution: fixed labels Sep 23, 2019
@Splaktar Splaktar assigned Splaktar and unassigned devversion Sep 23, 2019
@Splaktar
Copy link
Member

Reopening this as the PR that closed it was reverted in 1.1.2 and I can reproduce it in this updated CodePen.

@Splaktar Splaktar reopened this Sep 23, 2019
@Splaktar Splaktar mentioned this issue Sep 23, 2019
Open
Splaktar added a commit that referenced this issue Sep 30, 2019
@Splaktar
fix(list): dense lists cut off descenders of letters like gjqpy
64feb8b 
update demo to include letters with descenders
fix demo layout on mobile

Fixes #8890
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue type: spec alignment For issues related to aligning with the Material Design Spec labels Sep 30, 2019
@Splaktar Splaktar mentioned this issue Sep 30, 2019
Merged
3 tasks
@Splaktar
Copy link
Member

Opened PR #8482 to fix this.

@Splaktar Splaktar modified the milestones: 1.1.21, 1.1.22 Oct 22, 2019
Splaktar added a commit that referenced this issue Mar 5, 2020
@Splaktar
fix(list): dense lists cut off descenders of letters like gjqpy
0ab73bd 
update demo to include letters with descenders
fix demo layout on mobile

Fixes #8890
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed type: bug type: spec alignment For issues related to aligning with the Material Design Spec ui: CSS
Projects
None yet
Milestone
1.1.22
5 participants
@ThomasBurleson @Splaktar @lucasmaj @devversion @saleem-git