WIP: Refactor to use ngAria #316
Conversation
btford
force-pushed
the
refactor-ng-aria
branch
from
31898cb
to
1f04530
Compare
|
|
||
| function render() { | ||
| checked = ngModelCtrl.$viewValue; | ||
| element.attr(Constant.ARIA.PROPERTY.CHECKED, checked); |
There was a problem hiding this comment.
With removal of this line, aria-checked isn't being added even though ngAria is in place. Some bugs to iron out there.
There was a problem hiding this comment.
yeah, not sure how to go about this. also thinking if this model of composition for directives really makes sense. might be better to have a few different linking-like fns and mix them in to each individual directive.
There was a problem hiding this comment.
There does seem to be repetition amongst some of the Material directives. But the interaction models and required ARIA attributes amongst components are quite varied. What behaviors would you move into link functions?
|
I'm getting test failures when I run this branch: |
|
did you |
|
Derp! I did, but then I switched branches. Thanks. |
|
haha it happens |
|
Still seeing the same problem after |
|
weiiird. lemme try bumping the deps. |
|
@marcysutton – can pull and try with 31898cb ? |
|
@btford works! I'll get started on some tests. |
|
great. thanks! |
|
@btford I'm wondering if we should recreate this PR in the material repo so that it's easier to rebase/merge. Right now I have to experiment with it as a separate fork. |
|
@btford I cherry-picked these commits into the Material repo. Closing this PR! |
|
thx! On Fri, Sep 26, 2014 at 2:34 PM, Marcy Sutton notifications@github.com
|
|
I'm still getting ngAria errors: Error: [$injector:modulerr] Failed to instantiate module ngMaterial due to: My relevant bower.json entries are: "angular-material": "master" I bower-installed an bower ls says: #1.3.0-rc.4 So everything is updated, but I still get the ngAria problem. |
|
@janesconference This PR was closed and the remainder of the work was moved to the main Angular Material repo. Have you experienced this problem on master? |
|
@marcysutton yep, my bower entry is "angular-material": "master" and I'm currently at commit 914bed7916 (the last current one as I'm writing - angular/bower-material@914bed7). |
|
|
|
Yep, bower install angular-aria --save works. I don't know what was I thinking. Thank you. |
Still getting some tests to pass; we might need to make some changes to ngAria to get the material switch component to work.
/cc @marcysutton