This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Refactor to use ngAria #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 |
|
I'm noticing a lot of whitespace noise in these diffs. Can we make sure that everyone on material design configures their editor to strip whitespace from EOL on save? |
|
@btford totally. I'll do that now. |
|
Actually, it looks like I'm already configured to strip trailing spaces--the noise in this PR is from my text editor being configured differently than the other authors. |
ThomasBurleson
force-pushed
the
master
branch
from
56e270a
to
fd7697d
Compare
marcysutton
force-pushed
the
refactor-ng-aria
branch
3 times, most recently
from
834dd85
to
584f0d6
Compare
| @@ -20,8 +21,8 @@ describe('<material-switch>', function() { | |||
|
|
|||
| expect(cbElements.eq(0).hasClass(CHECKED_CSS)).toEqual(false); | |||
| expect(cbElements.eq(1).hasClass(CHECKED_CSS)).toEqual(true); | |||
| expect(cbElements.eq(0).attr('aria-checked')).toEqual('false'); | |||
| expect(cbElements.eq(1).attr('aria-checked')).toEqual('true'); | |||
| // expect(cbElements.eq(0).attr('aria-checked')).toEqual('false'); | |||
There was a problem hiding this comment.
Commented out while awaiting #321
|
Whitespace cleaned up, this is ready to go. |
marcysutton
added
resolution: fixed
a11y
| @@ -12,7 +12,7 @@ angular.module('material.components.button', [ | |||
| .directive('materialButton', [ | |||
| 'ngHrefDirective', | |||
| '$materialInkRipple', | |||
| '$aria', | |||
| '$materialAria', | |||
marcysutton
force-pushed
the
refactor-ng-aria
branch
from
584f0d6
to
f31bebe
Compare
|
Closed with 03051d3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates @btford's commits from #316 and relates to #314.
One outstanding issue with this change:
material-switchneeds refactoring to be supported (Material-switch needs refactoring #321), ARIA-specific tests have been commented out