Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): Position incorrect if selection scrolled. #6354

Closed
wants to merge 1 commit into from

Commits on Dec 17, 2015

  1. fix(select): Position incorrect if selection scrolled.

    If the currently selected object scrolled into view because it
    was further down in the list, the position of the menu was
    incorrect upon opening because the `scrollTop` of the `contentNode`
    was always `0` due to the ARIA changes which set it to
    `display: none` upon closing.
    
    Fix by modifying the display to `block` when we run the `isScrollable`
    check and back afterward (usually `display: none` but we account for
    other options).
    
    Also fixes a slight `2px` positioning issue which made the menu not
    perfectly line up with the underlying selection.
    
    Fixes #6190.
    topherfangio committed Dec 17, 2015
    Configuration menu
    Copy the full SHA
    81acf67 View commit details
    Browse the repository at this point in the history