Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent parameters naming for file and acl modules #124

Closed
selivan opened this issue Dec 16, 2020 · 3 comments · Fixed by #202
Closed

Consistent parameters naming for file and acl modules #124

selivan opened this issue Dec 16, 2020 · 3 comments · Fixed by #202
Assignees
@Akasurde
Labels
bug This issue/PR relates to a bug. has_pr

Comments

@selivan
Copy link

selivan commented Dec 16, 2020

SUMMARY

In file module we have parameter recurse. In acl module we have parameter recursive. I often use wrong one for each module. I think, it would be more convenient for both modules to accept both forms, but declare one of forms deprecated. It won't break existing playbooks and people will gradually start using one form(not deprecated).

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

file

acl

ADDITIONAL INFORMATION

Issue moved from here: ansible/ansible#14127 because now this is separate repository.
@selivan selivan mentioned this issue Dec 16, 2020
Closed
Akasurde added a commit to Akasurde/ansible.posix that referenced this issue Jun 4, 2021
@Akasurde
acl: Add new alias
7bd1b18 
Added new alias ``recurse`` for parameter ``recursive``.

Fixes: ansible-collections#124

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this issue Jun 4, 2021
Merged
@Akasurde
Copy link
Member

Akasurde commented Jun 4, 2021

@selivan Thanks for reporting this issue. Could you please check #202 and let me know if it works for you? Thanks.

@Akasurde
Copy link
Member

Akasurde commented Jun 4, 2021

resolved_by_pr #202

@Akasurde Akasurde added bug This issue/PR relates to a bug. has_pr needs_info labels Jun 4, 2021
Akasurde added a commit to Akasurde/ansible.posix that referenced this issue Jun 4, 2021
@Akasurde
acl: Add new alias
6ba8445 
Added new alias ``recurse`` for parameter ``recursive``.

Fixes: ansible-collections#124

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde self-assigned this Jun 7, 2021
@selivan
Copy link
Author

selivan commented Jun 11, 2021 •
edited
Loading

@Akasurde Thank you, looks good.

@renovate renovate bot mentioned this issue Aug 25, 2021
Merged
1 task
@renovate renovate bot mentioned this issue Apr 19, 2022
Merged
1 task
This was referenced Aug 19, 2022
Closed
Closed
This was referenced Sep 14, 2022
Closed
Closed
@renovate-tests renovate-tests mentioned this issue Nov 24, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akasurde Akasurde

Labels
bug This issue/PR relates to a bug. has_pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acl: Add new alias Akasurde/ansible.posix
2 participants
@Akasurde @selivan