Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: Add new alias #202

Merged
merged 1 commit into from
Jun 7, 2021
Merged

acl: Add new alias #202

merged 1 commit into from
Jun 7, 2021

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 4, 2021

SUMMARY

Added new alias recurse for parameter recursive.

Fixes: #124

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/124_acl.yml
plugins/modules/acl.py

Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
Does this have any effect when argument_spec have not been changed?

changelogs/fragments/124_acl.yml Outdated Show resolved Hide resolved
plugins/modules/acl.py Outdated Show resolved Hide resolved
Added new alias ``recurse`` for parameter ``recursive``.

Fixes: ansible-collections#124

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde
Copy link
Member Author

Akasurde commented Jun 7, 2021

/rebuild_failed

@Akasurde Akasurde closed this Jun 7, 2021
@Akasurde Akasurde reopened this Jun 7, 2021
@Akasurde Akasurde added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label Jun 7, 2021
@ansible-zuul ansible-zuul bot merged commit 7417d85 into ansible-collections:main Jun 7, 2021
@Akasurde Akasurde deleted the i124 branch June 7, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent parameters naming for file and acl modules
2 participants