add no_log=False to clear false-positives

[quidame]

SUMMARY

Ansible sanity test validate-modules triggers false-positives and hints no-log-needed errors for module parameters containing either key or passin their names, as in:

2021-03-16 20:27:04.127992 | centos-8 | ERROR: Found 3 validate-modules issue(s) which need to be resolved:
2021-03-16 20:27:04.128105 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 20:27:04.128204 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key_options' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 20:27:04.128303 | centos-8 | ERROR: plugins/modules/mount.py:0:0: no-log-needed: Argument 'passno' in argument_spec could be a secret, though doesn't have `no_log` set

This PR bypasses these errors by explicitly setting no_log=False in module's argument_spec.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

mount
authorized_key

ADDITIONAL INFORMATION

See also ansible-collections/community.network@af60326

[Akasurde]

recheck

[quidame]

It seems Ansible Zuul check ansible-changelog-fragment is a little bit tricky. https://github.com/ansible/project-config/blob/master/playbooks/ansible-changelog-fragment/run.yaml says:

shell: git show --name-status --exit-code --oneline --diff-filter=A | grep changelogs/fragments/

This succeeds if, and only if, a changelog fragment has been added (not modified) in the last commit (not the previous ones). That means that the last commit MUST contain the add of the changelog fragment.

I squashed all commits of the PR and force-pushed to make the changelog fragment added in the last commit, and ansible-changelog-fragment succeeded this time.

Is it the expected behavior ?

[Andersson007]

@justjais ^^

[pabelanger]

Yes, each PR needs a changelog fragment. However, the way that github PRs work, you can push up a new commit in your PR (with that changelog) and the check system will pass.

Or you can squash as you did for a single commit.

[quidame]

@pabelanger why not, but the error message says:

"Your pull-request is missing a changelog fragment, please add one. It should explain to end users the reason for your change."

I'm just clever enough to understand that something else than the changelog fragment is missing, because I know there is a changelog fragment. The message didn't help me. I find it confusing when, say, a contributor applies changes suggested by a reviewer, and then what was a successful check suddenly fails over and over. Only the read of the source code and testing my first hypothesis after reading the git-show's manual page lead me to a solution to make the check succeeds.

If the message says the PR is missing a changelog fragment and the PR contains a changelog fragment, my obvious conclusion is that the message is wrong. And if the current behavior is the expected one, as you explained me, I think the message is definitively wrong.

"Your last commit is missing a changelog fragment. It should explain to end users the reason for your change. Please add one, or if already present in a previous commit, squash them to make the changelog fragment added in the last commit."

or something else would be of better help :) thanks

[Andersson007]

cc @Akasurde

[Akasurde]

@quidame Thanks for the contribution. @Andersson007 Thanks for the review.

[Andersson007]

@quidame @Akasurde @pabelanger thanks!