new module: filesize, create or resize a file, given its size

[quidame]

SUMMARY

New module filesize to create a file or resize it. This is a simple wrapper around dd that allows to grow or reduce (truncate) a file to any arbitrary size. Useful to manage swap files.

Supports check_mode and diff.

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

filesize

ADDITIONAL INFORMATION

Example:

- name: create/resize a swap file
  filesize:
    path: /var/swap
    size: 2G
    mode: u=rw,go=
    group: root
    owner: root
  become: yes
  diff: yes

[quidame]

Ansible Zuul check ansible-changelog-fragment fails due to

2021-03-16 20:05:43.117394 | TASK [Changelog fragment failed]
2021-03-16 20:05:43.197785 | localhost | ERROR
2021-03-16 20:05:43.198122 | localhost | {
2021-03-16 20:05:43.198195 | localhost |   "msg": "Your pull-request is missing a changelog fragment, please add one. It should explain to end users the reason for your change."
2021-03-16 20:05:43.198261 | localhost | }

Does a new module need a changelog fragment ? If yes, what could be a valid changelog fragment entry ?

---
new_modules:
  - module_name - short description (PR URL)

thanks for help

[quidame]

Ansible Zuul check ansible-test-sanity-docker fails against other modules than this one, and it also seems to be false positives (at least for the mount module, since passno has nothing to do with a password or any kind of secret):

2021-03-16 20:27:04.127992 | centos-8 | ERROR: Found 3 validate-modules issue(s) which need to be resolved:
2021-03-16 20:27:04.128105 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 20:27:04.128204 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key_options' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 20:27:04.128303 | centos-8 | ERROR: plugins/modules/mount.py:0:0: no-log-needed: Argument 'passno' in argument_spec could be a secret, though doesn't have `no_log` set

This issue is addressed by this targeted PR now: #156

[Andersson007]

@quidame , hi, though I'm not a specialist in this area but it looks like a great job:)

[Andersson007]

@quidame update about changelog fragments - I've just noticed that the collection require it.
create a fragment with an entry of type trivial:. It will be ignored when building release notes but will allow to pass the check

trivial:
- filesize - new module to create or resize a file (https://github.com/ansible-collections/ansible.posix/pull/148).

[Andersson007]

Also i can see sanity issues:

2021-03-16 22:23:06.394805 | centos-8 | ERROR: Found 3 validate-modules issue(s) which need to be resolved:
2021-03-16 22:23:06.395046 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 22:23:06.395276 | centos-8 | ERROR: plugins/modules/authorized_key.py:0:0: no-log-needed: Argument 'key_options' in argument_spec could be a secret, though doesn't have `no_log` set
2021-03-16 22:23:06.395490 | centos-8 | ERROR: plugins/modules/mount.py:0:0: no-log-needed: Argument 'passno' in argument_spec could be a secret, though doesn't have `no_log` set

It's not about your module. Ignore it.

[Andersson007]

@quidame once it's ready for review, please let me know, I'll try to ping other folks

[Andersson007]

I've just pinged the other engineers.

[quidame]

@Andersson007 yeah ! thanks

[Andersson007]

recheck

[Andersson007]

@quidame there's only the changelog issue left. Please do what you did to get rid of it:)

[quidame]

@Andersson007 , done :)

[Andersson007]

@quidame thanks, I pinged folks in IRC that it's ready for review

[Andersson007]

LGTM (the idea, documentation formatting, tests, and other general things). Though I'm not an expert.

[Andersson007]

@quidame also FYI - this collection is officially supported and available on Automation hub, so the barrier to get new stuff merged here is much higher than, say, in c.g., resp. time between "ts created" and "ts merged" can be much longer as well.

I suggest waiting for some time and, if it doesn't get merged during April, we could move it to community.general.
What do you think?

[quidame]

@Andersson007 , thanks for the review !

I suggest waiting for some time and, if it doesn't get merged during April, we could move it to community.general.
What do you think?

Sounds good to me.

[Andersson007]

@quidame hi, it's still not the end of the month but we've discuss with @felixfontein that the PR content could be moved to community.general and it seems to be fine. If you're ok with it, feel free to move now or wait until May (which, IMO, doesn't make a lot of sense). What do you think?

[quidame]

@Andersson007 @felixfontein OK, moved to ansible-collections/community.general#2232.
I close this one.

[Andersson007]

@quidame great, thanks!