Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: filesize - create or resize a file, given its size #2232

Merged
merged 8 commits into from
Apr 19, 2021
Merged

new module: filesize - create or resize a file, given its size #2232

merged 8 commits into from
Apr 19, 2021

Conversation

quidame
Copy link
Collaborator

@quidame quidame commented Apr 13, 2021 •
edited
Loading

Moved from ansible-collections/ansible.posix#148

SUMMARY

New module filesize to create a file or resize it. This is a simple wrapper around dd that allows to grow or reduce (truncate) a file to any arbitrary size. Useful to manage swap files.

Supports check_mode and diff.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

filesize

ADDITIONAL INFORMATION

Example:

- name: create/resize a swap file
  filesize:
    path: /var/swap
    size: 2G
    mode: u=rw,go=
    group: root
    owner: root
  become: yes
  diff: yes

@quidame quidame mentioned this pull request Apr 13, 2021
Closed
aminvakil
aminvakil reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/files/filesize.py Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 13, 2021
@quidame quidame requested a review from aminvakil April 13, 2021 23:07
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 13, 2021
aminvakil
aminvakil approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from (#2232 (comment)) LGTM.

I won't insist on this change though.

felixfontein
felixfontein reviewed Apr 15, 2021
View reviewed changes
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 17, 2021
@quidame quidame marked this pull request as draft April 17, 2021 17:13
quidame and others added 3 commits April 17, 2021 21:39
@quidame
new module: filesize
a02501c 
* description: create or resize a file, given its size
* with integration tests
@quidame @Andersson007
Update plugins/modules/files/filesize.py (version_added)
37b15c2 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@quidame @aminvakil
Update filesize.py (extends_documentation_fragment: use fqcn)
ece9ef7 
Co-authored-by: Amin Vakil <info@aminvakil.com>
@quidame quidame marked this pull request as ready for review April 17, 2021 20:02
felixfontein
felixfontein reviewed Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I spotted a few more details, but besides that everything's great!

plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
plugins/modules/files/filesize.py Outdated Show resolved Hide resolved
quidame and others added 2 commits April 17, 2021 22:59
@quidame @felixfontein
Apply suggestions from code review
cf5e425 
Co-authored-by: Felix Fontein <felix@fontein.de>
@quidame
add more details
8460ecb
@felixfontein
Copy link
Collaborator

Assuming CI passes and nobody complains, I'll merge by Monday or so :)

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 19, 2021
@felixfontein felixfontein merged commit f87a39b into ansible-collections:main Apr 19, 2021
@felixfontein
Copy link
Collaborator

@quidame thanks for contributing this!
@Andersson007 @aminvakil thanks for reviewing!

@Andersson007 Andersson007 mentioned this pull request Apr 19, 2021
Merged
@quidame quidame deleted the new_module/filesize branch June 14, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@aminvakil aminvakil aminvakil approved these changes

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
community_review files integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quidame @ansibullbot @felixfontein @aminvakil @Andersson007