osx_defaults: add expand_user_and_vars flag to write (#5243) (#5260)

* Add expand_user_and_vars flag to write Closes #5234 * Add changelog * Update changelogs/fragments/5243-osx-defaults-expand-user-flags.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit f929422) Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
ansible-collections · Sep 10, 2022 · bc32914 · bc32914
1 parent 21ad7c8
commit bc32914
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/5243-osx-defaults-expand-user-flags.yml b/changelogs/fragments/5243-osx-defaults-expand-user-flags.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - osx_defaults - no longer expand ``~`` in ``value`` to the user's home directory, or expand environment variables (https://github.com/ansible-collections/community.general/issues/5234, https://github.com/ansible-collections/community.general/pull/5243).
diff --git a/plugins/modules/system/osx_defaults.py b/plugins/modules/system/osx_defaults.py
@@ -304,7 +304,8 @@ def write(self):
         if not isinstance(value, list):
             value = [value]
 
-        rc, out, err = self.module.run_command(self._base_command() + ['write', self.domain, self.key, '-' + self.type] + value)
+        rc, out, err = self.module.run_command(self._base_command() + ['write', self.domain, self.key, '-' + self.type] + value,
+                                               expand_user_and_vars=False)
 
         if rc != 0:
             raise OSXDefaultsException('An error occurred while writing value to defaults: %s' % out)