Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx_defaults: add expand_user_and_vars flag to write #5243

Merged
merged 3 commits into from
Sep 10, 2022

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Sep 6, 2022

SUMMARY

Fixes #5234

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

osx defaults

ADDITIONAL INFORMATION

cf #5234

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review system labels Sep 6, 2022
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Sep 6, 2022
@felixfontein felixfontein changed the title Add expand_user_and_vars flag to write osx_defaults: add expand_user_and_vars flag to write Sep 6, 2022
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Sep 6, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
@pavelzw
Copy link
Contributor Author

pavelzw commented Sep 6, 2022

Thanks for your help @felixfontein!

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge in a few days if nobody complains.

@github-actions

This comment was marked as off-topic.

@felixfontein felixfontein merged commit f929422 into ansible-collections:main Sep 10, 2022
@patchback
Copy link

patchback bot commented Sep 10, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/f929422dacbd0f69f42fe43b26fbc4470984d09a/pr-5243

Backported as #5260

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 10, 2022
patchback bot pushed a commit that referenced this pull request Sep 10, 2022
* Add expand_user_and_vars flag to write

Closes #5234

* Add changelog

* Update changelogs/fragments/5243-osx-defaults-expand-user-flags.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit f929422)
@felixfontein
Copy link
Collaborator

@pavelzw thanks again for your contribution!

@pavelzw pavelzw deleted the patch-1 branch September 10, 2022 09:18
felixfontein pushed a commit that referenced this pull request Sep 10, 2022
* Add expand_user_and_vars flag to write

Closes #5234

* Add changelog

* Update changelogs/fragments/5243-osx-defaults-expand-user-flags.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit f929422)

Co-authored-by: Pavel Zwerschke <pavelzw@gmail.com>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
…ions#5243)

* Add expand_user_and_vars flag to write

Closes ansible-collections#5234

* Add changelog

* Update changelogs/fragments/5243-osx-defaults-expand-user-flags.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
…ions#5243)

* Add expand_user_and_vars flag to write

Closes ansible-collections#5234

* Add changelog

* Update changelogs/fragments/5243-osx-defaults-expand-user-flags.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
This was referenced Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

~ gets evaluated when using community.general.osx_defaults
3 participants