Feat/tbrom 241 batch new #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add input fields for batch evaluation add snapshot generation in batch fix issue with _update_tbrom_inmcs which did not update twin_runtime inputs properly (and therefore lead to wrong results for any method using it like initialization, step by step evaulation)
for more information, see https://pre-commit.ci
|
I am worried the unit tests are running on Ubuntu but not on windows. Do you know why? |
keep __del__ as original implemented (fix passing of exsting unit testing) disable 1 TBROM unit testing given bug858312
…ytwin into feat/tbrom_241_batch_new
for more information, see https://pre-commit.ci
…ytwin into feat/tbrom_241_batch_new
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 88.04% 86.10% -1.95%
==========================================
Files 11 11
Lines 2209 2274 +65
==========================================
+ Hits 1945 1958 +13
- Misses 264 316 +52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add input fields for batch evaluation
add snapshot generation in batch
fix issue with _update_tbrom_inmcs which did not update twin_runtime inputs properly (and therefore lead to wrong results for any method using it like initialization, step by step evaulation)
add new unit test for batch evaluation with input fields (and adapt del method)