-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tbrom 241 public api refactoring #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lboucin
commented
Jun 27, 2023
•
edited
Loading
edited
- Refactor public methods signature
- Remove useless public methods or methods
- Reorganize test_tbrom module
- Update example 06
- Refactor the way error string are maintained
- Remove any usage of pytest.raises(...) in unit tests (since it was causing some dark issues in the unit test)
for more information, see https://pre-commit.ci
…b.com/ansys/pytwin into feat/tbrom_241_public_api_refactoring
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 88.04% 88.57% +0.53%
==========================================
Files 11 11
Lines 2209 2224 +15
==========================================
+ Hits 1945 1970 +25
+ Misses 264 254 -10 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
chrpetre
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks, let's merge it and continue on a new one with the latest development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.