Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: Draft Drilldown POC #1120

Closed
wants to merge 3 commits into from

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented May 18, 2021

🏆 Enhancements
Draft Drilldown POC

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner May 18, 2021 10:05
@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Cid2qsmuSDrtiWYNDXKhHS3HKECR
✅ Preview: Failed

@zhaoyongjie zhaoyongjie changed the title feat: Draft for Drilldown POC feat: Draft Drilldown POC May 18, 2021
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment wrt typing, other than that looks good (pending the ongoing discussion on wether or not to have drilldown in chart metadata or dataset metadata).

filters: QueryObjectFilterClause[];
}

export type OwnState = JsonObject & { drilldown: DrillDownType; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to enforce type checking on OwnState, we probably need to introduce some named properties while moving the custom ones into nested ones. Something like

{
  drilldown: DrillDownType;
  customState: JsonObject;
}

In the above example the previous ownState would be moved into customState, while drilldown would be a reserved property for drilldown actions. However, that refactor should probably not be done in this PR, so I propose leaving ownState as JsonObject for now.

@jhult
Copy link

jhult commented Jul 20, 2021

@zhaoyongjie and @villebro,

Any news on this? It would be great to have this implemented.

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

  • core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
  • plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants