Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Draft drilldown POC #14688

Closed
wants to merge 2 commits into from
Closed

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented May 18, 2021

SUMMARY

This PR introduces drilldown on explore and dashboard. notice that drilldown is an experimental feature.

Associated PR in superset-ui: apache-superset/superset-ui#1120

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Drilldown on explore

drilldown.on.explore.mp4

Drilldown on dashboard

drilldown.on.dashboard.mp4

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@skymarstroy
Copy link

Look forword to this feat.

@jhult
Copy link
Contributor

jhult commented Jul 20, 2021

This looks great. Besides the related PR in superset-ui, does anything else need to be done before this is merged?

@zhaoyongjie
Copy link
Member Author

Hi @ skymarstroy @jhult , This feature needs more design. I will update this PR soon. Thank you for your interest!
cc @junlincc

@walkmansun
Copy link

walkmansun commented Aug 26, 2021

hi @zhaoyongjie, I modified my files according to the code mentioned,but there are something wrong:

98% after emitting SizeLimitsPluginERROR in D:/superset_1.3/superset/superset-frontend/src/explore/components/controls/DrillDownControl/DrillDownControl.tsx(23,10):
TS2305: Module '"@superset-ui/core"' has no exported member 'DrillDown'.

what can I do? thank you very much

superset 1.3

@Vygo
Copy link

Vygo commented Aug 31, 2021

Is going in anytime soon? We'd love to use this functionality and considering hacking it together ourselves if this is not a priority/on the roadmap.

This was referenced Sep 19, 2021
@junryan
Copy link

junryan commented Nov 8, 2021

how to add drilldown feat to 'mixed time series' chat,I tried your method(eg: echat-pie),but it doesn't work

@caladogan
Copy link

Hi, is drill down feature usable in version 1.3?

@EvilDrW EvilDrW mentioned this pull request Dec 28, 2021
9 tasks
@EvilDrW
Copy link

EvilDrW commented Dec 28, 2021

For those following this PR, I have taken the liberty of bringing this feature up-to-date with the fairly recent superset reorg into a mono repo. I've also extended the functionality to work the bar charts. Those changes are in #17883.

@sujithzebpay
Copy link

Is this drilldown feature got released ?

@noureentaj
Copy link

Can we please have this released? It's a critical feature we need , awesome addition

@stale
Copy link

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 1, 2022
@HeathLee
Copy link

will this be released?

@zhaoyongjie
Copy link
Member Author

will this be released?

Superset3.0 might release this.

@stale stale bot removed the inactive Inactive for >= 30 days label Jun 17, 2022
@bnitesh
Copy link

bnitesh commented Jun 29, 2022

Superset 3.0 might be quite a while. Can we have this in a 2.x please? This is one of the highly requested features by our customers and PR looks good in video!

@xinchanghao
Copy link

@zhaoyongjie @superset-ui/core/DrillDown is not available in version 0.17.46, why do you can import?:smile:

@zhaoyongjie
Copy link
Member Author

Hi @xinchanghao, the superset-ui had been part of the superset repo. This PR is going to implement in the master in the future.

@xinchanghao
Copy link

Hi @xinchanghao, the superset-ui had been part of the superset repo. This PR is going to implement in the master in the future.

I see. Thank you 😃

@cue-parashar
Copy link

Any ETA of the release?

@lf-floriandin
Copy link

lf-floriandin commented Dec 7, 2022

Would really love this feature. Hope there will be some progress soon

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Dec 7, 2022

I am also waiting for this feature on the master, I think Preset has lots of engineers tackling this one and will bring a fantastic Drill feature in the future. isn't it? @rusackas

@muneebsajjad-zameen
Copy link

@zhaoyongjie thanks for your effort, so are you expecting your branch to be merged in the future? or someone from the preset will finally work on it and release this feature ?

@rusackas
Copy link
Member

rusackas commented Dec 8, 2022

Indeed, I don't think we're going to merge this... I'll just close it, with a proper round of applause for @zhaoyongjie for proving out so much with this effort.

Preset (and anyone who want to join!) are working on a stepped approach to drilling. Drill to Details is already shipping, Drill By (where you pick any column to drill into) is in flight, and then the final step will be mapping hierarchical relationships at the semantic layer to enable more automagic drill-down/drill-up actions. There's always more to do here (chart support and so forth) so we welcome extra sets of hands in this effort! Hit me up on Slack if you want to coordinate!

@rusackas rusackas closed this Dec 8, 2022
@crazyisjen
Copy link

drill by is similar with cross-filter (drill-through)?

@rusackas
Copy link
Member

drill by is similar with cross-filter (drill-through)?

Cross-filters are a different story entirely. Drill by is KIND OF like Drill Down, but instead of the right-click menu automatically knowing which filter+groupBy is "down" by knowing a hierarchy, drillBy lets you pick an arbitrary column to group by. This could be the next hierarchical layer, or... anything else.

I'll try to explain all this in a blogpost and/or meetup in the new year.

@strangerjam
Copy link

awesome feature, looking forward to it
@rusackas do you have any idea when this feature might be released?

@rusackas
Copy link
Member

rusackas commented Feb 6, 2023

Not yet... as always, there's a competition for time/resource prioritization :)

@nomed
Copy link

nomed commented Jul 14, 2023

Any update on this topic ?

@rusackas
Copy link
Member

Any update on this topic ?

You can now use DRILL_BY to drill into supported charts in dashboards. Preset's docs cover this pretty well, and there was a meetup that covers it too. The approach on this PR was a POC, but it was decided that specifying hierarchies for each and every chat was too much workflow overhead.

@sundar68
Copy link

@zhaoyongjie
I want to modify dashboard native filters whenever using this drilldown feature. Can you please help me with that.
email: sundarkeerthi222@gmail.com

@nitin-kumar12
Copy link

@rusackas @zhaoyongjie Will we get this feature in the future? We eagerly waiting for drill down / drill up feature. Current drill to details and drill by features are working only on the same database table while we need drill down to another table.

@rusackas
Copy link
Member

Drilling to another table isn't really drill-down, as most people use the term. Can you give a use case you'd have in mind on a new "Ideas" thread on GitHub Discussions (see link above)? If you want to discuss a new feature, let's do so, but not on this thread, please :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.