Add endpoint_url in test_connection

[ieunea1128]

---

In this pull request, we are resolving an issue related to the failure of the test connection caused by an incorrect STS URL. With this pull request, I've ensure that if the 'test_endpoint_url' parameter is provided, the STS check will be performed using that specific URL. However, if the parameter is not provided, the default URL will be used instead.

related: #32652

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Please set up pre-commit (see link in the above comment) and fix static check failures.

[vincbeck]

Did you tested it when test_endpoint_url is None. My experience with boto3 is they make a difference between a parameter value being None and a parameter not provided to the function

[ieunea1128]

Both of them returned successful result when I've tested both being None and a parameter not provided to the function.

I've executed code below

conn = Connection(
    conn_id="sample_aws_connection",
    conn_type="aws",
    login="access_key",  # Reference to AWS Access Key ID
    password="secret_key",  # Reference to AWS Secret Access Key
    extra={
        "test_endpoint_url": "https://sts.us-east-1.amazonaws.com",
        "region_name": "us-east-1"
    },
)

env_key = f"AIRFLOW_CONN_{conn.conn_id.upper()}"
conn_uri = conn.get_uri()
os.environ[env_key] = conn_uri
conn.test_connection()

and I've compared results of two connection. Both of them returned successful result, and there's difference of RequestID in ResponseMetadata and x-amzn-requestid, date in HTTPHeaders

conn_info = session.client(
	"sts",
	endpoint_url=test_endpoint_url,
	).get_caller_identity()

conn_info_without_endpoint_url = session.client(
	"sts"
	).get_caller_identity()

Could you let me know if there's anything I've missed?

[ieunea1128]

Oops there's difference in endpoint of sts session. When I've printed endpoint, former returns url of test_endpoint_url and later returns Global endpoint.

[vincbeck]

In the code you provided, you dont test when endpoint_url is None but I assume you tested it as you said. LGTM then

[ieunea1128]

@vincbeck After making the mentioned change, the test for test_hook_connection_test_failed in test/providers/amazon/aws/hooks/test_base_aws.py started asserting an error due to the absence of the test_endpoint_url in mock_sts_client. To resolve this, I will make the necessary modifications.
By the way, Would it be better to include a unit test specifically for test_endpoint_url to ensure its validity?

[vincbeck]

@vincbeck After making the mentioned change, the test for test_hook_connection_test_failed in test/providers/amazon/aws/hooks/test_base_aws.py started asserting an error due to the absence of the test_endpoint_url in mock_sts_client. To resolve this, I will make the necessary modifications. By the way, Would it be better to include a unit test specifically for test_endpoint_url to ensure its validity?

That would be great :)

[ieunea1128]

@vincbeck I've added unit test for test_endpoint_url. Would you mind to review my code?

[vincbeck]

LGTM. I'll merge it once the CI is green

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.