Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setup endpoint_url per-service in AWS Connection #34593

Merged

Conversation

Taragolis
Copy link
Contributor

  • Allow specify endpoint_url for the different services in the single AWS connection, this also allow use STS endpoint during Assume Role.
  • Deprecate undocumented test_endpoint_url (Add endpoint_url in test_connection #32664) by service_config: {"sts": {"endpoint_url": <sts_service_endpoint_url>}}

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincbeck vincbeck merged commit dd325b4 into apache:main Sep 28, 2023
43 checks passed
@Taragolis Taragolis deleted the amazon-connection-per-service-endpoint branch September 28, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants