GH-34385: [Go] Read IPC files with compression enabled but uncompressed buffers #34476
Conversation
|
|
go/arrow/ipc/ipc.go
Outdated
| // Note that enabling this option may result in unreadable data for Arrow | ||
| // C++ versions prior to 12.0.0. |
There was a problem hiding this comment.
Doesn't this also apply to go? (Or else, why did we have problems in the integration test if this only affected C++ readers?)
There was a problem hiding this comment.
gah, my fault for copying the comment, i'll fix it and update.
github-actions
bot
added
awaiting committer review
|
Hmm, looks like CGO is having issues across multiple PRs |
|
@lidavidm Yea, looks like the issue is that macOS is missing the openssl lib for some reason, I 'll open a PR for it soon |
|
Addressed the failing macos issue with #34488 |
|
Benchmark runs are scheduled for baseline = f7fbfca and contender = 864ba82. 864ba82 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
Fixing a bug in compressing buffers by prepending -1 when a buffer is not compressed due to size.
Are these changes tested?
Unit tests added, and other tests will be enabled via integration tests in #15194