Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [Go][CI] Add openssl to macos CGO runs #34488

Merged
merged 6 commits into from
Mar 7, 2023
Merged

MINOR: [Go][CI] Add openssl to macos CGO runs #34488

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1c1a33
MINOR: [Go][CI] Add openssl to macos CGO runs
zeroshade Mar 7, 2023
32dbaa5
reinstall openssl
zeroshade Mar 7, 2023
aa00a1a
lets try this
zeroshade Mar 7, 2023
d750b9a
Update .github/workflows/go.yml
zeroshade Mar 7, 2023
5255932
Update .github/workflows/go.yml
zeroshade Mar 7, 2023
23bb923
Update .github/workflows/go.yml
zeroshade Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,9 @@ jobs:
run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }}
- name: Build
shell: bash
run: ci/scripts/go_build.sh $(pwd)
run: |
echo "PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect in this step.

We need a separated step:

- name: Prepare PKG_CONFIG_PATH
  shell: bash
  run: |
    echo "PKG_CONFIG_PATH=$(brew --prefix openssl)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
- name: Build
  shell: bash
  run: ci/scripts/go_build.sh $(pwd)
...

And this change causes YAML syntax error: https://github.com/apache/arrow/actions/runs/4358242702/workflow#L308

I think that the indentation of this line is a problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry about that. Hmm, the UI didn't seem to have shown that in the PR itself...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also weird how the workflow didn't run on the last commit. Sorry for the indentation error that happens due to my comment suggestion 🙈

ci/scripts/go_build.sh $(pwd)
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
Expand Down