added pdb version detection #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinCai
approved these changes
Jun 21, 2022
michaeljmarshall
requested changes
Oct 18, 2022
There was a problem hiding this comment.
I think we'll need to take this comment into consideration here #183 (comment). @yuweisung are you able to test if this is an issue for this PR? Thanks!
update the capabilities syntax
update capability syntax
update capability version syntax
update capability version syntax
|
Thanks @yuweisung! |
fix typo
|
I verified manually that this PR works against minikube running k8s v1.25.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pod disruption budget version warning
Motivation
PDB policy api version, v1beta1 is deprecated in k8s1.21+ (not available in 1.25+).
Modifications
zookeeper-pdb, proxy-pdb, broker-pdb and bookkeepr-pdb templates are modified. If k8s api-resources container policy/v1, the *-pdb.yaml will generate respective apiVersion.
Verifying this change