Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-49741][DOCS] Add spark.shuffle.accurateBlockSkewedFactor to config docs page #48189

Closed
wants to merge 3 commits into from
Closed

[SPARK-49741][DOCS] Add spark.shuffle.accurateBlockSkewedFactor to config docs page #48189

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d4d6bc
add config
timlee0119 Sep 20, 2024
8c59fc6
move config location
timlee0119 Sep 20, 2024
0e9ac02
remove internal
timlee0119 Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,19 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>2.2.1</td>
</tr>
<tr>
<td><code>spark.shuffle.accurateBlockSkewedFactor</code></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the spark.shuffle.accurateBlockThreshold configuration is already documented in this table. It looks like we're preexistingly inconsistent about alphabetizing this list.

What do you think about either moving this new configuration a bit further down so it's next to spark.shuffle.accurateBlockThreshold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, also updated the test section
image

<td>-1.0</td>
<td>
A shuffle block is considered as skewed and will be accurately recorded in
<code>HighlyCompressedMapStatus</code> if its size is larger than this factor multiplying
the median shuffle block size or <code>spark.shuffle.accurateBlockThreshold</code>. It is
recommended to set this parameter to be the same as
<code>spark.sql.adaptive.skewJoin.skewedPartitionFactor</code>. Set to -1.0 to disable this
feature by default.
</td>
<td>3.3.0</td>
</tr>
<tr>
<td><code>spark.shuffle.compress</code></td>
<td>true</td>
Expand Down