Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saved query): handle null sql field #11679

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Nov 12, 2020

SUMMARY

There's an error in the typing of SavedQueryObject, sql field can be null which causes the preview modal to error out.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • manually tested that a blank query does not error out in the saved query preview modal

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #11679 (c14d6c6) into master (95246e8) will decrease coverage by 2.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11679      +/-   ##
==========================================
- Coverage   62.86%   60.25%   -2.61%     
==========================================
  Files         889      843      -46     
  Lines       43054    41339    -1715     
  Branches     4016     3729     -287     
==========================================
- Hits        27064    24909    -2155     
- Misses      15811    16265     +454     
+ Partials      179      165      -14     
Flag Coverage Δ
cypress 55.96% <0.00%> (?)
javascript ?
python 62.56% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx 10.86% <0.00%> (-74.32%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-80.00%) ⬇️
... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95246e8...c8c3616. Read the comment docs.

@nytai nytai force-pushed the tai/fix-saved-query-null-sql branch from f6d366c to c14d6c6 Compare November 13, 2020 01:20
@nytai
Copy link
Member Author

nytai commented Nov 13, 2020

retriggering CI

@nytai nytai closed this Nov 13, 2020
@nytai nytai reopened this Nov 13, 2020
@nytai nytai force-pushed the tai/fix-saved-query-null-sql branch from c14d6c6 to c8c3616 Compare November 13, 2020 22:43
@nytai nytai merged commit 218f58e into apache:master Nov 13, 2020
@nytai nytai deleted the tai/fix-saved-query-null-sql branch November 13, 2020 23:15
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants