fix(saved query): handle null sql field (apache#11679)

auxten · Nov 20, 2020 · 5eb0654 · 5eb0654
1 parent 206c9b4
commit 5eb0654
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/savedquery/SavedQueryPreviewModal.tsx b/superset-frontend/src/views/CRUD/data/savedquery/SavedQueryPreviewModal.tsx
@@ -162,7 +162,7 @@ const SavedQueryPreviewModal: FunctionComponent<SavedQueryPreviewModalProps> = (
         <QueryTitle>query name</QueryTitle>
         <QueryLabel>{savedQuery.label}</QueryLabel>
         <SyntaxHighlighter language="sql" style={github}>
-          {savedQuery.sql}
+          {savedQuery.sql || ''}
         </SyntaxHighlighter>
       </StyledModal>
     </div>

diff --git a/superset-frontend/src/views/CRUD/types.ts b/superset-frontend/src/views/CRUD/types.ts
@@ -56,6 +56,6 @@ export type SavedQueryObject = {
   id: number;
   label: string;
   schema: string;
-  sql: string;
+  sql: string | null;
   sql_tables?: { catalog?: string; schema: string; table: string }[];
 };