feat: View all fav charts and dashboards

[geido]

SUMMARY

Allows to show fav Charts and Dashboards from the Welcome page, by clicking the "Favorite" tab and "View all". It also removes the "Favorite" tab for "Saved Queries" as this functionality is not implemented yet.

TEST PLAN

1. Login in Superset
2. From the Welcome page click on "Favorite" for the "Dashboards" collapse and click "View all".
3. OR From the Welcome page click on "Favorite" for the "Charts" collapse and click "View all".
4. Check that only fav Charts/Dashboards are shown.
5. Change the filter on the top from "Favorite": "Yes" to "Favorite": "None".
6. Check that no favorites are shown.
7. Change the filter on the top from "Favorite": "No" to "Favorite": "Any".
8. Check that both fav and non-fav are shown
9. Go back to the Welcome page and check that no "Favorite" tab is shown for "Saved Queries"

ADDITIONAL INFORMATION

• Has associated issue: Use can't get to all his favorite dashboards from the new welcome page #11984
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[geido]

@rusackas @junlincc

[codecov-io]

Codecov Report

Merging #12060 (d248677) into master (dd5cdb1) will decrease coverage by 1.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12060      +/-   ##
==========================================
- Coverage   64.71%   63.25%   -1.46%     
==========================================
  Files         960      478     -482     
  Lines       47302    29445   -17857     
  Branches     4629        0    -4629     
==========================================
- Hits        30611    18626   -11985     
+ Misses      16517    10819    -5698     
+ Partials      174        0     -174     

Flag	Coverage Δ
cypress	?
javascript	?
python	63.25% <ø> (-0.93%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/databases/commands/create.py	32.65% <0.00%> (-59.19%)	⬇️
superset/sql_validators/postgres.py	50.00% <0.00%> (-50.00%)	⬇️
superset/db_engine_specs/hive.py	54.61% <0.00%> (-29.62%)	⬇️
superset/views/database/mixins.py	59.64% <0.00%> (-22.81%)	⬇️
superset/db_engine_specs/presto.py	69.95% <0.00%> (-12.45%)	⬇️
superset/db_engine_specs/mysql.py	79.59% <0.00%> (-12.25%)	⬇️
superset/databases/commands/update.py	85.71% <0.00%> (-8.17%)	⬇️
superset/databases/dao.py	94.11% <0.00%> (-5.89%)	⬇️
superset/views/database/validators.py	78.94% <0.00%> (-5.27%)	⬇️
... and 495 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5cdb1...d248677. Read the comment docs.

[junlincc]

Show a list of favorite dashboards and charts only by clicking View All from the Favorite tab ✅
Remove/hide Favorite tab from Saved Queries section ✅
LGTM, but please make sure to address comments from @etr2460
Thanks so much @geido 🙏
cc: @pkdotson

[geido]

@nytai @rusackas @junlincc all requests resolved. Another review is appreciated.

[rusackas]

This LGTM! I think the follow-up PR addresses the only remaining concern brought up on this.

[nytai]

LGTM. Thanks making those changes

[kode-magic]

This finally saved my day, thanks guys.