feat: View all fav charts and dashboards

superset-frontend/spec/javascripts/components/ListView/ListView_spec.jsx

@@ -409,6 +409,7 @@ describe('ListView', () => {
         Object {
           "filters": Array [
             Object {
+              "col": undefined,
               "id": "id",
               "operator": "eq",
               "value": "bar",
@@ -431,11 +432,13 @@ describe('ListView', () => {
         Object {
           "filters": Array [
             Object {
+              "col": undefined,
               "id": "id",
               "operator": "eq",
               "value": "bar",
             },
             Object {
+              "col": undefined,
               "id": "name",
               "operator": "ct",
               "value": "something",

superset-frontend/spec/javascripts/views/CRUD/welcome/SavedQueries_spec.tsx

@@ -96,7 +96,7 @@ describe('SavedQueries', () => {
     expect(wrapper.find(SavedQueries)).toExist();
   });
 
-  it('fetches queries favorites and renders listviewcard cards', async () => {
+  it('fetches queries mine and renders listviewcard cards', async () => {
     clickTab(0);
     await waitForComponentToPaint(wrapper);
     expect(fetchMock.calls(/saved_query\/\?q/)).toHaveLength(1);
@@ -105,9 +105,9 @@ describe('SavedQueries', () => {
 
   it('it renders a submenu with clickable tables and buttons', async () => {
     expect(wrapper.find(SubMenu)).toExist();
-    expect(wrapper.find('li')).toHaveLength(2);
+    expect(wrapper.find('li')).toHaveLength(1);
     expect(wrapper.find('button')).toHaveLength(2);
-    clickTab(1);
+    clickTab(0);
     await waitForComponentToPaint(wrapper);
     expect(fetchMock.calls(/saved_query\/\?q/)).toHaveLength(2);
   });

superset-frontend/src/components/ListView/types.ts

@@ -55,11 +55,14 @@ type FilterOperator =
   | 'all_text'
   | 'chart_all_text'
   | 'dataset_is_null_or_empty'
-  | 'between';
+  | 'between'
+  | 'dashboard_is_fav'
+  | 'chart_is_fav';
 
 export interface Filter {
   Header: ReactNode;
   id: string;
+  col?: string;
   operator?: FilterOperator;
   input?:
     | 'text'
@@ -85,6 +88,7 @@ export type ViewModeType = 'card' | 'table';
 
 export interface FilterValue {
   id: string;
+  col?: string;
   operator?: string;
   value: string | boolean | number | null | undefined | string[] | number[];
 }
@@ -119,4 +123,6 @@ export enum FilterOperators {
   chartAllText = 'chart_all_text',
   datasetIsNullOrEmpty = 'dataset_is_null_or_empty',
   between = 'between',
+  dashboardIsFav = 'dashboard_is_fav',
+  chartIsFav = 'chart_is_fav',
 }

superset-frontend/src/components/ListView/utils.ts

@@ -80,10 +80,10 @@ type QueryFilterState = {
 };
 
 function mergeCreateFilterValues(list: Filter[], updateObj: QueryFilterState) {
-  return list.map(({ id, operator }) => {
+  return list.map(({ id, operator, col }) => {
     const update = updateObj[id];
 
-    return { id, operator, value: update };
+    return { id, col, operator, value: update };
   });
 }
 
@@ -97,26 +97,29 @@ export function convertFilters(fts: InternalFilter[]): FilterValue[] {
           (Array.isArray(f.value) && !f.value.length)
         ),
     )
-    .map(({ value, operator, id }) => {
+    .map(({ value, operator, id, col }) => {
       // handle between filter using 2 api filters
       if (operator === 'between' && Array.isArray(value)) {
         return [
           {
             value: value[0],
             operator: 'gt',
             id,
+            col,
           },
           {
             value: value[1],
             operator: 'lt',
             id,
+            col,
           },
         ];
       }
       return {
         value,
         operator,
         id,
+        col,
       };
     })
     .flat();
@@ -147,6 +150,7 @@ export function convertFiltersRison(
 
     if (filter) {
       filter.operator = value.operator;
+      filter.col = value.col;
     }
   });
 
@@ -318,6 +322,7 @@ export function useListViewState({
         : 'replace';
 
     setQuery(queryParams, method);
+
     fetchData({ pageIndex, pageSize, sortBy, filters });
   }, [fetchData, pageIndex, pageSize, sortBy, filters, viewMode]);
 

superset-frontend/src/views/CRUD/chart/ChartList.tsx

@@ -444,6 +444,18 @@ function ChartList(props: ChartListProps) {
       ),
       paginate: false,
     },
+    {
+      Header: t('Favorite'),
+      id: 'favorite',
+      col: 'id',
+      input: 'select',
+      operator: 'chart_is_fav',
+      unfilteredLabel: 'Any',
+      selects: [
+        { label: t('Yes'), value: true },
+        { label: t('No'), value: false },
+      ],
+    },
     {
       Header: t('Search'),
       id: 'slice_name',

superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx

@@ -69,6 +69,7 @@ interface Dashboard {
   dashboard_title: string;
   id: number;
   published: boolean;
+  favorite: boolean;
   url: string;
   thumbnail_url: string;
   owners: Owner[];
@@ -101,6 +102,7 @@ function DashboardList(props: DashboardListProps) {
     dashboardIds,
     addDangerToast,
   );
+
   const [dashboardToEdit, setDashboardToEdit] = useState<Dashboard | null>(
     null,
   );
@@ -400,6 +402,18 @@ function DashboardList(props: DashboardListProps) {
         { label: t('Unpublished'), value: false },
       ],
     },
+    {
+      Header: t('Favorite'),
+      id: 'favorite',
+      col: 'id',
+      input: 'select',
+      operator: 'dashboard_is_fav',
+      unfilteredLabel: 'Any',
+      selects: [
+        { label: t('Yes'), value: true },
+        { label: t('No'), value: false },
+      ],
+    },
     {
       Header: t('Search'),
       id: 'dashboard_title',

superset-frontend/src/views/CRUD/hooks.ts

@@ -114,8 +114,8 @@ export function useListViewResource<D extends object = any>(
 
       const filterExps = baseFilters
         .concat(filterValues)
-        .map(({ id: col, operator: opr, value }) => ({
-          col,
+        .map(({ id, operator: opr, value, col }) => ({
+          col: col || id,
           opr,
           value,
         }));

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx

@@ -155,7 +155,10 @@ function ChartTable({
             name: 'View All »',
             buttonStyle: 'link',
             onClick: () => {
-              window.location.href = '/chart/list';
+              window.location.href =
+                chartFilter === 'Favorite'
+                  ? '/chart/list/?filters=(favorite:!t)'
+                  : '/chart/list/';
             },
           },
         ]}

superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx

@@ -162,7 +162,10 @@ function DashboardTable({
             name: 'View All »',
             buttonStyle: 'link',
             onClick: () => {
-              window.location.href = '/dashboard/list/';
+              window.location.href =
+                dashboardFilter === 'Favorite'
+                  ? '/dashboard/list/?filters=(favorite:!t)'
+                  : '/dashboard/list/';
             },
           },
         ]}

superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx

@@ -255,13 +255,15 @@ const SavedQueries = ({
       <SubMenu
         activeChild={queryFilter}
         tabs={[
+          /* @TODO uncomment when fav functionality is implemented
           {
             name: 'Favorite',
             label: t('Favorite'),
             onClick: () => {
               getData('Favorite').then(() => setQueryFilter('Favorite'));
             },
           },
+          */
           {
             name: 'Mine',
             label: t('Mine'),