fix: making the new chart/dashboard buttons on the homepage work

[rusackas]

SUMMARY

The code was previously using history.push, which wasn't working... window.location.assign works like a charm though!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TEST PLAN

Tested locally, but others can/should/will verify

ADDITIONAL INFORMATION

• Has associated issue: Fixes [Home] +DASHBOARD and +CHART button don't work #12346
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[nytai]

Jinx! #12348

[rusackas]

Jinx! #12348

Hah! That is one beautiful PR you have there, if I may say so myself.

[nytai]

This because we're living in the confusing world where only half our app is in react router 😞

[rusackas]

This because we're living in the confusing world where only half our app is in react router 😞

... just for now... it'll get better.

[codecov-io]

Codecov Report

Merging #12347 (b7a19dc) into master (cbda599) will increase coverage by 1.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #12347      +/-   ##
==========================================
+ Coverage   66.03%   67.04%   +1.00%     
==========================================
  Files        1001     1001              
  Lines       49380    49380              
  Branches     5033     5033              
==========================================
+ Hits        32609    33107     +498     
+ Misses      16612    16145     -467     
+ Partials      159      128      -31     

Flag	Coverage Δ
cypress	51.22% <0.00%> (+7.46%)	⬆️
javascript	60.99% <0.00%> (ø)
python	64.18% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx	76.59% <0.00%> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx	63.07% <0.00%> (ø)
superset/db_engine_specs/presto.py	82.68% <0.00%> (-0.65%)	⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx	83.03% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	61.96% <0.00%> (+0.21%)	⬆️
.../explore/components/controls/DateFilterControl.jsx	56.32% <0.00%> (+0.57%)	⬆️
...c/dashboard/components/nativeFilters/FilterBar.tsx	53.14% <0.00%> (+0.69%)	⬆️
.../src/explore/components/AdhocMetricEditPopover.jsx	74.56% <0.00%> (+0.87%)	⬆️
.../src/explore/components/ControlPanelsContainer.jsx	91.13% <0.00%> (+1.26%)	⬆️
superset-frontend/src/reduxUtils.ts	79.74% <0.00%> (+1.26%)	⬆️
... and 74 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbda599...b7a19dc. Read the comment docs.

[junlincc]

impressive you both~ im pulling......

[junlincc]

thank you both @rusackas @nytai !!