Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(home): use window.location for views not registered in react-router #12348

Closed
wants to merge 1 commit into from
Closed

fix(home): use window.location for views not registered in react-router #12348

wants to merge 1 commit into from

Conversation

nytai
Copy link
Member

@nytai nytai commented Jan 8, 2021

SUMMARY

Some views are not registered with react router, we need to use window.location to navigate to them programmatically.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • clicking +Dashboard and +Chart on the homescreen works as it should

ADDITIONAL INFORMATION

@nytai nytai mentioned this pull request Jan 8, 2021
Merged
6 tasks
@nytai nytai closed this Jan 8, 2021
@nytai nytai deleted the tai/fix-home-new-buttons branch January 8, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preset-io size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Home] +DASHBOARD and +CHART button don't work
1 participant
@nytai